On Wed, Aug 31, 2016 at 9:45 AM, Junio C Hamano wrote:
> Jacob Keller writes:
>
>>> We probably should release for the error case. I'll do that. I don't
>>> believe do_submodule_path ensures that the passed in argument is
>>> guaranteed to not be
Jacob Keller writes:
>> We probably should release for the error case. I'll do that. I don't
>> believe do_submodule_path ensures that the passed in argument is
>> guaranteed to not be initialized or used.
>>
>> Thanks,
>> Jake
>
> Here's the squash for this fix.
It
From: Jacob Keller
> On Fri, Aug 26, 2016 at 1:04 PM, Jeff King wrote:
> > On Fri, Aug 26, 2016 at 07:58:07PM +, Keller, Jacob E wrote:
> >
> >> > > char *git_pathdup_submodule(const char *path, const char *fmt,
> >> > > ...)
> >> > > {
> >> > > +
On Fri, Aug 26, 2016 at 1:04 PM, Jeff King wrote:
> On Fri, Aug 26, 2016 at 07:58:07PM +, Keller, Jacob E wrote:
>
>> > > char *git_pathdup_submodule(const char *path, const char *fmt,
>> > > ...)
>> > > {
>> > > + int err;
>> > > va_list args;
>> > >
On Fri, Aug 26, 2016 at 07:58:07PM +, Keller, Jacob E wrote:
> > > char *git_pathdup_submodule(const char *path, const char *fmt,
> > > ...)
> > > {
> > > + int err;
> > > va_list args;
> > > struct strbuf buf = STRBUF_INIT;
> > > va_start(args, fmt);
> > > -
On Fri, 2016-08-26 at 12:17 -0700, Stefan Beller wrote:
> On Thu, Aug 25, 2016 at 4:32 PM, Jacob Keller om> wrote:
>
> >
> > @@ -487,12 +490,14 @@ static void do_submodule_path(struct strbuf
> > *buf, const char *path,
> > strbuf_addstr(buf, git_dir);
>
On Thu, Aug 25, 2016 at 4:32 PM, Jacob Keller wrote:
> @@ -487,12 +490,14 @@ static void do_submodule_path(struct strbuf *buf, const
> char *path,
> strbuf_addstr(buf, git_dir);
> }
> if (!is_git_directory(buf->buf)) {
> +
From: Jacob Keller
Modify the changes to do_submodule_path so that we properly call
gitmodules_config() before the lookup of submodule_from_path. This may
need to be modified so that we only call it the first time as I'm not
sure what sort of performance hit we'll see.
8 matches
Mail list logo