Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-03 Thread Pranit Bauva
On Tue, May 3, 2016 at 9:47 PM, Eric Sunshine wrote: > On Tue, May 3, 2016 at 5:18 AM, Pranit Bauva wrote: >> On Tue, May 3, 2016 at 12:19 PM, Eric Sunshine >> wrote: > Step back a moment and recall why these tests

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-03 Thread Eric Sunshine
On Tue, May 3, 2016 at 5:18 AM, Pranit Bauva wrote: > On Tue, May 3, 2016 at 12:19 PM, Eric Sunshine > wrote: Step back a moment and recall why these tests were added. Earlier rounds of this series were buggy and caused regressions in

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-03 Thread Junio C Hamano
Eric Sunshine writes: One previous commit (title: commit: add a commit.verbose config variable) introduced a new config variable named commit.verbose, so care should be taken that it would not affect the behavior of status. Another previous

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-03 Thread Pranit Bauva
On Tue, May 3, 2016 at 12:19 PM, Eric Sunshine wrote: > On Tue, May 3, 2016 at 2:42 AM, Pranit Bauva wrote: >> On Tue, May 3, 2016 at 10:42 AM, Eric Sunshine >> wrote: >>> On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-03 Thread Eric Sunshine
On Tue, May 3, 2016 at 2:42 AM, Pranit Bauva wrote: > On Tue, May 3, 2016 at 10:42 AM, Eric Sunshine > wrote: >> On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva wrote: >>> I agree that using test_expect_failure would be a

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-03 Thread Pranit Bauva
On Tue, May 3, 2016 at 10:42 AM, Eric Sunshine wrote: > On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva wrote: >> On Tue, May 3, 2016 at 4:37 AM, Junio C Hamano wrote: >>> Pranit Bauva writes:

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-02 Thread Eric Sunshine
On Mon, May 2, 2016 at 11:39 PM, Pranit Bauva wrote: > On Tue, May 3, 2016 at 4:37 AM, Junio C Hamano wrote: >> Pranit Bauva writes: >>> Variable named 'verbose' in builtin/commit.c is consumed by git-status >>> and git-commit

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-02 Thread Pranit Bauva
On Tue, May 3, 2016 at 4:37 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> Variable named 'verbose' in builtin/commit.c is consumed by git-status >> and git-commit so if a new verbose related behavior is introduced in >> git-commit, then it

Re: [PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-05-02 Thread Junio C Hamano
Pranit Bauva writes: > Variable named 'verbose' in builtin/commit.c is consumed by git-status > and git-commit so if a new verbose related behavior is introduced in > git-commit, then it should not affect the behavior of git-status. > > One previous commit (title: commit:

[PATCH v15 7/7] t/t7507: tests for broken behavior of status

2016-04-30 Thread Pranit Bauva
Variable named 'verbose' in builtin/commit.c is consumed by git-status and git-commit so if a new verbose related behavior is introduced in git-commit, then it should not affect the behavior of git-status. One previous commit (title: commit: add a commit.verbose config variable) introduced a new