Stephan Beyer writes:
> Hi again ;)
> ...
> In both of the above "error" calls, you should drop the final "\n"
> because "error" does that already.
>
> On the other hand, you have dropped the "\n"s of the orginal error
> messages. So it should probably be
>
> _("You need to give me at least one
Hi again ;)
On 10/27/2017 05:06 PM, Pranit Bauva wrote:
> @@ -44,6 +46,11 @@ static void set_terms(struct bisect_terms *terms, const
> char *bad,
> terms->term_bad = xstrdup(bad);
> }
>
> +static const char *voc[] = {
> + "bad|new",
> + "good|old"
> +};
> +
> /*
> * Check whet
> @@ -21,6 +22,7 @@ static const char * const git_bisect_helper_usage[] = {
> N_("git bisect--helper --bisect-reset []"),
> N_("git bisect--helper --bisect-write
> []"),
> N_("git bisect--helper --bisect-check-and-set-terms
> "),
> + N_("git bisect--helper --bisect-nex
Hi,
another minor:
On 10/27/2017 05:06 PM, Pranit Bauva wrote:
> @@ -264,6 +271,79 @@ static int check_and_set_terms(struct bisect_terms
> *terms, const char *cmd)
> return 0;
> }
>
> +static int mark_good(const char *refname, const struct object_id *oid,
> + int flag,
On 27/10/17 16:06, Pranit Bauva wrote:
> Reimplement `bisect_next_check` shell function in C and add
> `bisect-next-check` subcommand to `git bisect--helper` to call it from
> git-bisect.sh .
>
> `bisect_voc` shell function is no longer useful now and is replaced by
> using a char *[] of "new|ba
Hey Martin,
On Fri, Oct 27, 2017 at 11:05 PM, Martin Ågren wrote:
> On 27 October 2017 at 17:06, Pranit Bauva wrote:
>> + /*
>> +* have bad (or new) but not good (or old). We could bisect
>> +* although this is less optimum.
>> +*/
>>
On 27 October 2017 at 17:06, Pranit Bauva wrote:
> + /*
> +* have bad (or new) but not good (or old). We could bisect
> +* although this is less optimum.
> +*/
> + fprintf(stderr, _("Warning: bisecting only with a %s
> co
Reimplement `bisect_next_check` shell function in C and add
`bisect-next-check` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
`bisect_voc` shell function is no longer useful now and is replaced by
using a char *[] of "new|bad" and "good|old" values.
Using `--bisect-next-check
8 matches
Mail list logo
