Re: [PATCH v2] *config.txt: stick to camelCase naming convention

2015-03-11 Thread Eric Sunshine
On Wed, Mar 11, 2015 at 07:20:18PM +0700, Nguyễn Thái Ngọc Duy wrote:
 This should improve readability. Compare thislongname and
 thisLongName. The following keys are left in unchanged. We can
 decide what to do with them later.
 
  - am.keepcr
  - core.autocrlf .safecrlf .trustctime
  - diff.dirstat .noprefix
  - gitcvs.usecrlfattr
  - gui.blamehistoryctx .trustmtime
  - pull.twohead
  - receive.autogc
  - sendemail.signedoffbycc .smtpsslcertpath .suppresscc
 
 Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
 ---
 diff --git a/Documentation/config.txt b/Documentation/config.txt
 index 1530255..54ae0f6 100644
 --- a/Documentation/config.txt
 +++ b/Documentation/config.txt
 @@ -237,7 +237,7 @@ The default is false, except linkgit:git-clone[1] or 
 linkgit:git-init[1]
  will probe and set core.ignorecase true if appropriate when the repository
  is created.
  
 -core.precomposeunicode::
 +core.precomposeUnicode::

There are numerous places in config.txt where a config variable is
mentioned in the description blurbs as well, so camel-casing it at just
the point of definition makes for an incomplete conversion.

   This option is only used by Mac OS implementation of Git.
   When core.precomposeunicode=true, Git reverts the unicode decomposition

Here is one such instance of the variable mentioned inline in a blurb.

These converted variables are also mentioned in a number of other
documentation files. Below is a more thorough conversion, covering all
instances. You may want to split it up for easier review.


--- 8 ---
From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= 
pclo...@gmail.com
Subject: [PATCH] *config.txt: stick to camelCase naming convention

This should improve readability. Compare thislongname and
thisLongName. The following keys are left in unchanged. We can
decide what to do with them later.

 - am.keepcr
 - core.autocrlf .safecrlf .trustctime
 - diff.dirstat .noprefix
 - gitcvs.usecrlfattr
 - gui.blamehistoryctx .trustmtime
 - pull.twohead
 - receive.autogc
 - sendemail.signedoffbycc .smtpsslcertpath .suppresscc

Helped-by: Eric Sunshine sunsh...@sunshineco.com
Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
Signed-off-by: Eric Sunshine sunsh...@sunshineco.com
---
 Documentation/CodingGuidelines |   2 +-
 Documentation/blame-options.txt|   2 +-
 Documentation/config.txt   | 242 ++---
 Documentation/diff-config.txt  |  10 +-
 Documentation/diff-options.txt |   4 +-
 Documentation/fetch-options.txt|   2 +-
 Documentation/git-add.txt  |   4 +-
 Documentation/git-apply.txt|   2 +-
 Documentation/git-branch.txt   |   6 +-
 Documentation/git-check-ignore.txt |   2 +-
 Documentation/git-checkout.txt |   4 +-
 Documentation/git-commit-tree.txt  |   2 +-
 Documentation/git-commit.txt   |   2 +-
 Documentation/git-config.txt   |   2 +-
 Documentation/git-cvsserver.txt|  22 ++--
 Documentation/git-fetch.txt|   2 +-
 Documentation/git-format-patch.txt |   4 +-
 Documentation/git-gc.txt   |  12 +-
 Documentation/git-init.txt |   2 +-
 Documentation/git-instaweb.txt |   2 +-
 Documentation/git-log.txt  |   2 +-
 Documentation/git-merge.txt|   4 +-
 Documentation/git-pull.txt |   2 +-
 Documentation/git-rebase.txt   |   6 +-
 Documentation/git-receive-pack.txt |   2 +-
 Documentation/git-repack.txt   |   4 +-
 Documentation/git-rerere.txt   |   2 +-
 Documentation/git-send-email.txt   |  50 
 Documentation/git-status.txt   |   4 +-
 Documentation/git-tag.txt  |   2 +-
 Documentation/git.txt  |   2 +-
 Documentation/gitattributes.txt|   2 +-
 Documentation/gitcredentials.txt   |   2 +-
 Documentation/gitignore.txt|   4 +-
 Documentation/gitweb.conf.txt  |   2 +-
 Documentation/merge-config.txt |   2 +-
 Documentation/user-manual.txt  |   2 +-
 37 files changed, 212 insertions(+), 212 deletions(-)

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 7636199..376d5ec 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -526,7 +526,7 @@ Writing Documentation:
  `backticks around word phrases`, do so.
`--pretty=oneline`
`git rev-list`
-   `remote.pushdefault`
+   `remote.pushDefault`
 
  Word phrases enclosed in `backtick characters` are rendered literally
  and will not be further expanded. The use of `backticks` to achieve the
diff --git a/Documentation/blame-options.txt b/Documentation/blame-options.txt
index 0cebc4f..b299b59 100644
--- a/Documentation/blame-options.txt
+++ b/Documentation/blame-options.txt
@@ -4,7 +4,7 @@
 
 --root::
Do not treat root commits as boundaries.  This can also be
-   controlled via the `blame.showroot` config option.
+   controlled via the `blame.showRoot` config option.
 
 --show-stats::
Include additional statistics at the end of blame 

[PATCH v2] *config.txt: stick to camelCase naming convention

2015-03-11 Thread Nguyễn Thái Ngọc Duy
This should improve readability. Compare thislongname and
thisLongName. The following keys are left in unchanged. We can
decide what to do with them later.

 - am.keepcr
 - core.autocrlf .safecrlf .trustctime
 - diff.dirstat .noprefix
 - gitcvs.usecrlfattr
 - gui.blamehistoryctx .trustmtime
 - pull.twohead
 - receive.autogc
 - sendemail.signedoffbycc .smtpsslcertpath .suppresscc

Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
---
 Documentation/config.txt   | 190 -
 Documentation/diff-config.txt  |   8 +-
 Documentation/merge-config.txt |   2 +-
 3 files changed, 100 insertions(+), 100 deletions(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 1530255..54ae0f6 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -225,7 +225,7 @@ See linkgit:git-update-index[1].
 +
 The default is true (when core.filemode is not specified in the config file).
 
-core.ignorecase::
+core.ignoreCase::
If true, this option enables various workarounds to enable
Git to work better on filesystems that are not case sensitive,
like FAT. For example, if a directory listing finds
@@ -237,7 +237,7 @@ The default is false, except linkgit:git-clone[1] or 
linkgit:git-init[1]
 will probe and set core.ignorecase true if appropriate when the repository
 is created.
 
-core.precomposeunicode::
+core.precomposeUnicode::
This option is only used by Mac OS implementation of Git.
When core.precomposeunicode=true, Git reverts the unicode decomposition
of filenames done by Mac OS. This is useful when sharing a repository
@@ -264,13 +264,13 @@ core.trustctime::
crawlers and some backup systems).
See linkgit:git-update-index[1]. True by default.
 
-core.checkstat::
+core.checkStat::
Determines which stat fields to match between the index
and work tree. The user can set this to 'default' or
'minimal'. Default (or explicitly 'default'), is to check
all fields, including the sub-second part of mtime and ctime.
 
-core.quotepath::
+core.quotePath::
The commands that output paths (e.g. 'ls-files',
'diff'), when not given the `-z` option, will quote
unusual characters in the pathname by enclosing the
@@ -476,7 +476,7 @@ core.compression::
If set, this provides a default to other compression variables,
such as 'core.loosecompression' and 'pack.compression'.
 
-core.loosecompression::
+core.looseCompression::
An integer -1..9, indicating the compression level for objects that
are not in a pack file. -1 is the zlib default. 0 means no
compression, and 1..9 are various speed/size tradeoffs, 9 being
@@ -537,7 +537,7 @@ be delta compressed, but larger binary media files won't be.
 +
 Common unit suffixes of 'k', 'm', or 'g' are supported.
 
-core.excludesfile::
+core.excludesFile::
In addition to '.gitignore' (per-directory) and
'.git/info/exclude', Git looks into this file for patterns
of files which are not meant to be tracked.  `~/` is expanded
@@ -546,7 +546,7 @@ core.excludesfile::
If $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/ignore
is used instead. See linkgit:gitignore[5].
 
-core.askpass::
+core.askPass::
Some commands (e.g. svn and http interfaces) that interactively
ask for a password can be told to use an external program given
via the value of this variable. Can be overridden by the 'GIT_ASKPASS'
@@ -555,7 +555,7 @@ core.askpass::
prompt. The external program shall be given a suitable prompt as
command-line argument and write the password on its STDOUT.
 
-core.attributesfile::
+core.attributesFile::
In addition to '.gitattributes' (per-directory) and
'.git/info/attributes', Git looks into this file for attributes
(see linkgit:gitattributes[5]). Path expansions are made the same
@@ -569,7 +569,7 @@ core.editor::
variable when it is set, and the environment variable
`GIT_EDITOR` is not set.  See linkgit:git-var[1].
 
-core.commentchar::
+core.commentChar::
Commands such as `commit` and `tag` that lets you edit
messages consider a line that begins with this character
commented, and removes them after the editor returns
@@ -638,7 +638,7 @@ core.whitespace::
   is relevant for `indent-with-non-tab` and when Git fixes `tab-in-indent`
   errors. The default tab width is 8. Allowed values are 1 to 63.
 
-core.fsyncobjectfiles::
+core.fsyncObjectFiles::
This boolean will enable 'fsync()' when writing object files.
 +
 This is a total waste of time and effort on a filesystem that orders
@@ -646,7 +646,7 @@ data writes properly, but can be useful for filesystems 
that do not use
 journalling (traditional UNIX filesystems) or that only journal metadata
 and not file contents (OS X's HFS+, or Linux ext3 with data=writeback).