Re: [PATCH v2] Add support for -i/--interactive to git-clean

2013-04-29 Thread Jiang Xin
2013/4/29 Matthieu Moy : > Jiang Xin writes: > >> Show what would be done and a confirmation dialog before actually >> cleaning. In the confirmation dialog, the user can input a space >> separated prefix list, and each clean candidate that matches with >> one of prefix, will be excluded from clean

Re: [PATCH v2] Add support for -i/--interactive to git-clean

2013-04-29 Thread Matthieu Moy
Jiang Xin writes: > Show what would be done and a confirmation dialog before actually > cleaning. In the confirmation dialog, the user can input a space > separated prefix list, and each clean candidate that matches with > one of prefix, will be excluded from cleaning. That seems a really weird

Re: [PATCH v2] Add support for -i/--interactive to git-clean

2013-04-27 Thread Eric Sunshine
On Sat, Apr 27, 2013 at 12:13 PM, Jiang Xin wrote: > --- a/builtin/clean.c > +++ b/builtin/clean.c > @@ -257,26 +261,92 @@ int cmd_clean(int argc, const char **argv, const char > *prefix) > } > > if (S_ISDIR(st.st_mode)) { > - strbuf_addstr(&d

Re: [PATCH v2] Add support for -i/--interactive to git-clean

2013-04-27 Thread Junio C Hamano
Matthieu Moy writes: > Jiang Xin writes: > >> Reviewed-by: Matthieu Moy > > Err, no: I commented on the intention of the first patch, but did not > _review_ it, and didn't read this version yet. Yeah I suspected as such. And thanks for saying it loud in public, so that other contributors can

Re: [PATCH v2] Add support for -i/--interactive to git-clean

2013-04-27 Thread Matthieu Moy
Jiang Xin writes: > Reviewed-by: Matthieu Moy Err, no: I commented on the intention of the first patch, but did not _review_ it, and didn't read this version yet. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of

[PATCH v2] Add support for -i/--interactive to git-clean

2013-04-27 Thread Jiang Xin
Show what would be done and a confirmation dialog before actually cleaning. In the confirmation dialog, the user can input a space separated prefix list, and each clean candidate that matches with one of prefix, will be excluded from cleaning. When the user feels it's OK, press ENTER to start clean