Re: [PATCH v2] add: warn when -u or -A is used without filepattern

2013-01-27 Thread Jonathan Nieder
Hi Matthieu, Matthieu Moy wrote: --- a/builtin/add.c +++ b/builtin/add.c [...] @@ -392,8 +420,14 @@ int cmd_add(int argc, const char **argv, const char *prefix) die(_(-A and -u are mutually incompatible)); if (!show_only ignore_missing) die(_(Option

Re: [PATCH v2] add: warn when -u or -A is used without filepattern

2013-01-27 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: Matthieu Moy matthieu@imag.fr writes: Most git commands that can be used with our without a filepattern are tree-wide by default, the filepattern being used to restrict their scope. A few exceptions are: 'git grep', 'git clean', 'git add -u' and

Re: [PATCH v2] add: warn when -u or -A is used without filepattern

2013-01-27 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Plus, option_with_implicit_dot is used in cut-and-paste ready commands below. I do not think we should aim for easy cut-and-paste, especially when the real purpose of the change is to train people's fingers; the message should discouraging

[PATCH v2] add: warn when -u or -A is used without filepattern

2013-01-25 Thread Matthieu Moy
Most git commands that can be used with our without a filepattern are tree-wide by default, the filepattern being used to restrict their scope. A few exceptions are: 'git grep', 'git clean', 'git add -u' and 'git add -A'. The inconsistancy of 'git add -u' and 'git add -A' are particularly

Re: [PATCH v2] add: warn when -u or -A is used without filepattern

2013-01-25 Thread Junio C Hamano
Matthieu Moy matthieu@imag.fr writes: Most git commands that can be used with our without a filepattern are tree-wide by default, the filepattern being used to restrict their scope. A few exceptions are: 'git grep', 'git clean', 'git add -u' and 'git add -A'. The inconsistancy of 'git