Re: [PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread brian m. carlson
On Fri, May 12, 2017 at 07:23:04PM -0600, Alex Henrie wrote: > When I saw Brian's email today, my first thought was "What was I > thinking?" My mistake was pretty obvious. Then I remembered that when > I wrote the original patch, I wasn't sure where to set the default > value, because there were

Re: [PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread brian m. carlson
On Fri, May 12, 2017 at 04:48:14PM -0700, Jonathan Nieder wrote: > Hi, > > brian m. carlson wrote: > > > Does anyone else have views on whether this is good thing to test for? > > I know you don't mean to be rude, but this comes across as a bit of > a dismissive question. Sorry, that wasn't my

Re: [PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread Alex Henrie
2017-05-12 17:48 GMT-06:00 Jonathan Nieder : > Hi, > > brian m. carlson wrote: > >> Does anyone else have views on whether this is good thing to test for? > > I know you don't mean to be rude, but this comes across as a bit of > a dismissive question. The question sounded

Re: [PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread Jonathan Nieder
Hi, brian m. carlson wrote: > Does anyone else have views on whether this is good thing to test for? I know you don't mean to be rude, but this comes across as a bit of a dismissive question. > On Fri, May 12, 2017 at 04:32:14PM -0700, Jonathan Nieder wrote: >> brian m. carlson wrote: >>> The

Re: [PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread brian m. carlson
On Fri, May 12, 2017 at 04:32:14PM -0700, Jonathan Nieder wrote: > brian m. carlson wrote: > > > The recent change that introduced autodecorating of refs accidentally > > broke the ability of users to set log.decorate = false to override it. > > Yikes. It sounds to me like we need a test to

Re: [PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread Jonathan Nieder
brian m. carlson wrote: > The recent change that introduced autodecorating of refs accidentally > broke the ability of users to set log.decorate = false to override it. Yikes. It sounds to me like we need a test to ensure we don't regress it again later. > When the git_log_config was traversed

Re: [PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread Alex Henrie
2017-05-12 16:12 GMT-06:00 brian m. carlson : > The recent change that introduced autodecorating of refs accidentally > broke the ability of users to set log.decorate = false to override it. > When the git_log_config was traversed a second time with an option other >

[PATCH v2] builtin/log: honor log.decorate

2017-05-12 Thread brian m. carlson
The recent change that introduced autodecorating of refs accidentally broke the ability of users to set log.decorate = false to override it. When the git_log_config was traversed a second time with an option other than log.decorate, the decoration style would be set to the automatic style, even if