Re: [PATCH v2] gpg-interface: use more status letters

2016-10-10 Thread Junio C Hamano
Michael J Gruber writes: > Sorry, this got "lost in vacation". Before that, I was looking for an > easy way to test expired signatures, but gpg1 and gpg2 behave somewhat > differently in that respect (2 does not allow to create already expired > signatures). > > Is

Re: [PATCH v2] gpg-interface: use more status letters

2016-10-10 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 06.10.2016 23:43: > Junio C Hamano writes: > >> Michael J Gruber writes: >> >>> Also, I'm open to using another letter for EXPKEYSIG but couldn't decide >>> between 'Y', 'Z', 'K'. 'K' could be confused with

Re: [PATCH v2] gpg-interface: use more status letters

2016-10-06 Thread Junio C Hamano
Junio C Hamano writes: > Michael J Gruber writes: > >> Also, I'm open to using another letter for EXPKEYSIG but couldn't decide >> between 'Y', 'Z', 'K'. 'K' could be confused with REVKEYSIG, I'm afraid. >> 'Y' is next to 'X' and contained in 'KEY',

Re: [PATCH v2] gpg-interface: use more status letters

2016-09-30 Thread Michael J Gruber
Ramsay Jones venit, vidit, dixit 28.09.2016 23:09: > > > On 28/09/16 20:59, Junio C Hamano wrote: >> Michael J Gruber writes: > >>> + "X" for a good expired signature, or good signature made by an expired >>> key, >> >> As an attempt to clarify that we cover both

Re: [PATCH v2] gpg-interface: use more status letters

2016-09-30 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 28.09.2016 21:59: > Michael J Gruber writes: > >> - Use GNUPGHOME="$HOME/gnupg-home-not-used" just like in other tests (lib). > > If you are not using /dev/null, I expected you to do > > . ./test-lib.sh >

Re: [PATCH v2] gpg-interface: use more status letters

2016-09-28 Thread Ramsay Jones
On 28/09/16 20:59, Junio C Hamano wrote: > Michael J Gruber writes: >> + "X" for a good expired signature, or good signature made by an expired >> key, > > As an attempt to clarify that we cover both EXPSIG and EXPKEYSIG > cases, I think this is good enough. I

Re: [PATCH v2] gpg-interface: use more status letters

2016-09-28 Thread Junio C Hamano
Michael J Gruber writes: > - Use GNUPGHOME="$HOME/gnupg-home-not-used" just like in other tests (lib). If you are not using /dev/null, I expected you to do . ./test-lib.sh GNUPGHOME_saved=$GNPGHOME . "$TEST_DIRECTORY/lib-gpg.sh" and then use

Re: [PATCH v2] gpg-interface: use more status letters

2016-09-28 Thread Ramsay Jones
On 28/09/16 15:24, Michael J Gruber wrote: > According to gpg2's doc/DETAILS: > "For each signature only one of the codes GOODSIG, BADSIG, EXPSIG, > EXPKEYSIG, REVKEYSIG or ERRSIG will be emitted." > > gpg1 ("classic") behaves the same (although doc/DETAILS > differs). > > Currently, we parse

[PATCH v2] gpg-interface: use more status letters

2016-09-28 Thread Michael J Gruber
According to gpg2's doc/DETAILS: "For each signature only one of the codes GOODSIG, BADSIG, EXPSIG, EXPKEYSIG, REVKEYSIG or ERRSIG will be emitted." gpg1 ("classic") behaves the same (although doc/DETAILS differs). Currently, we parse gpg's status output for GOODSIG, BADSIG and trust information