Re: [PATCH v2] http: support sending custom HTTP headers

2016-04-27 Thread Johannes Schindelin
Hi Junio, On Tue, 26 Apr 2016, Junio C Hamano wrote: > Jeff King writes: > > > But I think this block (even before my patch) also needs to handle the > > case where "value" is NULL (presumably by complaining with > > config_error_nonbool). > > OK, so squashes found to be

Re: [PATCH v2] http: support sending custom HTTP headers

2016-04-27 Thread Johannes Schindelin
Hi Peff, On Tue, 26 Apr 2016, Jeff King wrote: > On Tue, Apr 26, 2016 at 10:20:19AM -0700, Junio C Hamano wrote: > > > Jeff King writes: > > > > > But I think this block (even before my patch) also needs to handle the > > > case where "value" is NULL (presumably by complaining

Re: [PATCH v2] http: support sending custom HTTP headers

2016-04-26 Thread Junio C Hamano
Johannes Schindelin writes: > diff --git a/Documentation/config.txt b/Documentation/config.txt > index 42d2b50..37b9af7 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -1655,6 +1655,12 @@ http.emptyAuth:: > a username in the

Re: [PATCH v2] http: support sending custom HTTP headers

2016-04-26 Thread Jeff King
On Tue, Apr 26, 2016 at 10:20:19AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > But I think this block (even before my patch) also needs to handle the > > case where "value" is NULL (presumably by complaining with > > config_error_nonbool). > > OK, so squashes found to

Re: [PATCH v2] http: support sending custom HTTP headers

2016-04-26 Thread Junio C Hamano
Jeff King writes: > But I think this block (even before my patch) also needs to handle the > case where "value" is NULL (presumably by complaining with > config_error_nonbool). OK, so squashes found to be necessary so far amounts to the attached patch. I still haven't figured

Re: [PATCH v2] http: support sending custom HTTP headers

2016-04-26 Thread Jeff King
On Tue, Apr 26, 2016 at 10:03:14AM -0700, Junio C Hamano wrote: > > +http.extraHeader:: > > + Pass an additional HTTP header when communicating with a server. If > > + more than one such entry exists, all of them are added as extra headers. > > + This feature is useful e.g. to increase

Re: [PATCH v2] http: support sending custom HTTP headers

2016-04-26 Thread Junio C Hamano
Johannes Schindelin writes: > We introduce a way to send custom HTTP headers with all requests. > > This allows us, for example, to send an extra token from build agents > for temporary access to private repositories. (This is the use case that > triggered this

[PATCH v2] http: support sending custom HTTP headers

2016-04-26 Thread Johannes Schindelin
We introduce a way to send custom HTTP headers with all requests. This allows us, for example, to send an extra token from build agents for temporary access to private repositories. (This is the use case that triggered this patch.) This feature can be used like this: git -c