[PATCH v2] line-log: fix crash when --first-parent is used

2014-11-04 Thread Tzvetan Mikov
line-log tries to access all parents of a commit, but only the first parent has been loaded if --first-parent is specified, resulting in a crash. Limit the number of parents to one if --first-parent is specified. Reported-by: Eric N. Vander Weele eri...@gmail.com Signed-off-by: Tzvetan Mikov

Re: [PATCH v2] line-log: fix crash when --first-parent is used

2014-11-04 Thread Junio C Hamano
Tzvetan Mikov tmi...@gmail.com writes: line-log tries to access all parents of a commit, but only the first parent has been loaded if --first-parent is specified, resulting in a crash. Limit the number of parents to one if --first-parent is specified. Reported-by: Eric N. Vander Weele

Re: [PATCH v2] line-log: fix crash when --first-parent is used

2014-11-04 Thread Tzvetan Mikov
On Tue, Nov 4, 2014 at 1:24 PM, Junio C Hamano gits...@pobox.com wrote: Thanks, both. The patch looks good (modulo the indentation of nparents assignment, which I'll locally fix up). Will queue. Awesome, thanks! (I can't believe I missed that tab. Well, at least one of my two lines was