Re: [PATCH v2] log: if --decorate is not given, default to --decorate=auto

Jeff King writes: > On Thu, Mar 30, 2017 at 11:03:51AM -0700, Junio C Hamano wrote: > >> With the "--decorate=auto" option becoming the default for "git >> log", "git tbdiff" will be broken. >> ... > I'm confused. I thought "auto" would kick in only when we are outputting > to a

Re: [PATCH v2] log: if --decorate is not given, default to --decorate=auto

On Thu, Mar 30, 2017 at 11:03:51AM -0700, Junio C Hamano wrote: > With the "--decorate=auto" option becoming the default for "git > log", "git tbdiff" will be broken. > > The configuration variable has been already there, so in that sense > this is not a new breakage (tbdiff wouldn't have worked

Re: [PATCH v2] log: if --decorate is not given, default to --decorate=auto

With the "--decorate=auto" option becoming the default for "git log", "git tbdiff" will be broken. The configuration variable has been already there, so in that sense this is not a new breakage (tbdiff wouldn't have worked well for those with configured default). A fix is trivial (attached). I

Re: [PATCH v2] log: if --decorate is not given, default to --decorate=auto

Alex Henrie wrote: > Signed-off-by: Alex Henrie > --- > builtin/log.c | 9 - > t/t4202-log.sh | 10 +- > 2 files changed, 17 insertions(+), 2 deletions(-) Nice. Reviewed-by: Jonathan Nieder

Re: [PATCH v2] log: if --decorate is not given, default to --decorate=auto

Alex Henrie writes: > +test_expect_success TTY 'log output on a TTY' ' > + git log --oneline --decorate >expect.short && > + > + test_terminal git log --oneline >actual && > + test_cmp expect.short actual > +' > + Nice. I didn't know test_terminal was so

[PATCH v2] log: if --decorate is not given, default to --decorate=auto

Signed-off-by: Alex Henrie --- builtin/log.c | 9 - t/t4202-log.sh | 10 +- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/builtin/log.c b/builtin/log.c index 281af8c1e..d755a5960 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -52,6