Re: [PATCH v2] ls-files: add pathspec matching for submodules

Junio C Hamano writes: > Brandon Williams writes: > >> On a similar but slightly different note. In general do we want >> the pathspec '??b' to match against the sib/ directory and >> subsequently have ls-files print all entries inside of the sib/ >>

Re: [PATCH v2] ls-files: add pathspec matching for submodules

Brandon Williams writes: > On a similar but slightly different note. In general do we want > the pathspec '??b' to match against the sib/ directory and > subsequently have ls-files print all entries inside of the sib/ > directory? (this is in the non-recursive case) I'd

Re: [PATCH v2] ls-files: add pathspec matching for submodules

>>> + >>> + if (item->flags & PATHSPEC_ONESTAR) { >>> + return WM_MATCH; >>> + } else if (item->magic & PATHSPEC_GLOB) { >>> + return wildmatch(pattern, string, >>> + WM_PATHNAME | >>> + (item->magic &

Re: [PATCH v2] ls-files: add pathspec matching for submodules

On Mon, Sep 19, 2016 at 4:21 PM, Junio C Hamano wrote: > > As the previous one that used a wrong (sorry) argument is not even > in 'next' yet, let's pretend that it never happened. It is OK to > still keep it and this patch as two separate steps, i.e. a topic > with two

Re: [PATCH v2] ls-files: add pathspec matching for submodules

Brandon Williams writes: > diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt > index a623ebf..09e4449 100644 > --- a/Documentation/git-ls-files.txt > +++ b/Documentation/git-ls-files.txt > @@ -19,7 +19,7 @@ SYNOPSIS > -

[PATCH v2] ls-files: add pathspec matching for submodules

Pathspecs can be a bit tricky when trying to apply them to submodules. The main challenge is that the pathspecs will be with respect to the super module and not with respect to paths in the submodule. The approach this patch takes is to pass in the identical pathspec from the super module to the