Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers

2017-10-04 Thread Jonathan Nieder
Junio C Hamano wrote: > From: Taylor Blau > Date: Mon, 2 Oct 2017 09:10:34 -0700 > Subject: [PATCH] ref-filter.c: pass empty-string as NULL to atom parsers > > Peff points out that different atom parsers handle the empty > "sub-argument" list differently. An example of this is

Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers

2017-10-04 Thread Junio C Hamano
Taylor Blau writes: > On Tue, Oct 03, 2017 at 08:55:01AM +0900, Junio C Hamano wrote: >> Jonathan Nieder writes: >> >> > The above does a nice job of explaining >> > >> > - what this change is going to do >> > - how it's good for the internal code

Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers

2017-10-02 Thread Taylor Blau
On Tue, Oct 03, 2017 at 08:55:01AM +0900, Junio C Hamano wrote: > Jonathan Nieder writes: > > > The above does a nice job of explaining > > > > - what this change is going to do > > - how it's good for the internal code structure / maintainability > > > > What it doesn't

Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers

2017-10-02 Thread Junio C Hamano
Jonathan Nieder writes: > The above does a nice job of explaining > > - what this change is going to do > - how it's good for the internal code structure / maintainability > > What it doesn't tell me about is why the user-facing effect won't > cause problems. Is there no

Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers

2017-10-02 Thread Jonathan Nieder
Hi, Taylor Blau wrote: > Peff points out that different atom parsers handle the empty > "sub-argument" list differently. An example of this is the format > "%(refname:)". > > Since callers often use `string_list_split` (which splits the empty > string with any delimiter as a 1-ary string_list

Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers

2017-10-02 Thread Jeff King
On Mon, Oct 02, 2017 at 09:10:34AM -0700, Taylor Blau wrote: > Peff points out that different atom parsers handle the empty > "sub-argument" list differently. An example of this is the format > "%(refname:)". > > Since callers often use `string_list_split` (which splits the empty > string with

[PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers

2017-10-02 Thread Taylor Blau
Peff points out that different atom parsers handle the empty "sub-argument" list differently. An example of this is the format "%(refname:)". Since callers often use `string_list_split` (which splits the empty string with any delimiter as a 1-ary string_list containing the empty string), this