Re: [PATCH v2] remote-mediawiki: limit filenames to legal

2017-10-30 Thread Antoine Beaupré
On 2017-10-30 11:34:11, Matthieu Moy wrote: > Antoine Beaupré writes: > >> @@ -52,7 +53,7 @@ sub smudge_filename { >> $filename =~ s/ /_/g; >> # Decode forbidden characters encoded in clean_filename >> $filename =~ s/_%_([0-9a-fA-F][0-9a-fA-F])/sprintf('%c',

Re: [PATCH v2] remote-mediawiki: limit filenames to legal

2017-10-30 Thread Matthieu Moy
Antoine Beaupré writes: > @@ -52,7 +53,7 @@ sub smudge_filename { > $filename =~ s/ /_/g; > # Decode forbidden characters encoded in clean_filename > $filename =~ s/_%_([0-9a-fA-F][0-9a-fA-F])/sprintf('%c', hex($1))/ge; > - return $filename; > +

[PATCH v2] remote-mediawiki: limit filenames to legal

2017-10-29 Thread Antoine Beaupré
mediawiki pages can have names longer than NAME_MAX (generally 255) characters, which will fail on checkout. we simply strip out extra characters, which may mean one page's content will overwrite another (the last editing winning). ideally, we would do a more clever system to find unique names,