Re: [PATCH v2 0/3] add -p: select individual hunk lines

2018-03-06 Thread Igor Djordjevic
Hi Junio, On 06/03/2018 22:03, Junio C Hamano wrote: > > > A small nitpick - I see you use phrasing like "select lines", where > > the other commands usually talk about "staging", instead, so "stage > > lines" might be more aligned with the existing text. > > Isn't this machinery shared

Re: [PATCH v2 0/3] add -p: select individual hunk lines

2018-03-06 Thread Junio C Hamano
Igor Djordjevic writes: > A small nitpick - I see you use phrasing like "select lines", where > the other commands usually talk about "staging", instead, so "stage > lines" might be more aligned with the existing text. Isn't this machinery shared across "add -p"

Re: [PATCH v2 0/3] add -p: select individual hunk lines

2018-03-06 Thread Igor Djordjevic
Hi Phillip, On 06/03/2018 11:17, Phillip Wood wrote: > > From: Phillip Wood > > I've added some documentation to git-add.txt for the new selection > mode and cleaned up some style issues, otherwise these are unchanged > since v1. These patches build on top of the

[PATCH v2 0/3] add -p: select individual hunk lines

2018-03-06 Thread Phillip Wood
From: Phillip Wood I've added some documentation to git-add.txt for the new selection mode and cleaned up some style issues, otherwise these are unchanged since v1. These patches build on top of the recount fixes in [1]. The commit message for the first patch