Re: [PATCH v2 0/6] convert various shell functions in git-bisect to C

2016-06-15 Thread Pranit Bauva
Hey Eric, On Wed, Jun 15, 2016 at 11:23 PM, Eric Sunshine wrote: > On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote: >> Changes wrt previous version: >> * Use STRING_LIST_INIT_NODUP to avoid leaks in bisect_clean_state() >> * Use

Re: [PATCH v2 0/6] convert various shell functions in git-bisect to C

2016-06-15 Thread Eric Sunshine
On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva wrote: > Changes wrt previous version: > * Use STRING_LIST_INIT_NODUP to avoid leaks in bisect_clean_state() > * Use test_path_is_missing in the patch 2/6 > * drop file_size() > * move is_empty_file() method from

[PATCH v2 0/6] convert various shell functions in git-bisect to C

2016-06-15 Thread Pranit Bauva
A previous version is available here[1]. Changes wrt previous version: * Use STRING_LIST_INIT_NODUP to avoid leaks in bisect_clean_state() * Use test_path_is_missing in the patch 2/6 * drop file_size() * move is_empty_file() method from builtin/am.c to wrapper.c * use static for methods *