Re: [PATCH v2 0/9] X509 (gpgsm) commit signing support

2018-07-16 Thread Jeff King
On Sat, Jul 14, 2018 at 06:33:12PM +, brian m. carlson wrote: > > This series is a fine replacement for that earlier work. It's flexible > > enough to allow what we really wanted out of that series (gpgsm support, > > or another drop-in tool that uses the same interface). It doesn't lay > > an

Re: [PATCH v2 0/9] X509 (gpgsm) commit signing support

2018-07-14 Thread brian m. carlson
On Tue, Jul 10, 2018 at 01:12:24PM -0400, Jeff King wrote: > On Tue, Jul 10, 2018 at 10:52:22AM +0200, Henning Schild wrote: > > This series can be seen as a follow up of a series that appeared under > > the name "gpg-interface: Multiple signing tools" in april 2018 [1]. After > > that series was n

Re: [PATCH v2 0/9] X509 (gpgsm) commit signing support

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 10:52:22AM +0200, Henning Schild wrote: > This series adds support for signing commits with gpgsm. Thanks for working on this. I left a bunch of comments, but overall the direction looks good. We talked about this a bit off-list, but just for the public record: > This se

[PATCH v2 0/9] X509 (gpgsm) commit signing support

2018-07-10 Thread Henning Schild
Changes in v2: - removed trailing commas in array initializers and add leading space - replaced assert(0) with BUG in p5 - consolidated 2 format lookups reusing get_format_data p5 - changed from format "PGP" to "openpgp", later X509 to "x509" - use strcasecmp instead of strcmp for format match