Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes
Junio C Hamano gits...@pobox.com writes: - Nobody has time or energy to go through 140+ patches in one go, with enough concentration necessary to do so without making mistakes (this applies to yourself, too---producing mechanical replacement is a no-cost thing, finding mistakes in mechanical replacement takes real effort). It's a bit less bad than it seems: 142 files changed, 609 insertions(+), 609 deletions(-) The first pass I did was a very quick one, but I already went through the patches I received (apparently not the whole series) and it wasn't that long. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes
On Wed, Mar 26, 2014 at 3:02 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Junio C Hamano gits...@pobox.com writes: - Nobody has time or energy to go through 140+ patches in one go, with enough concentration necessary to do so without making mistakes (this applies to yourself, too---producing mechanical replacement is a no-cost thing, finding mistakes in mechanical replacement takes real effort). It's a bit less bad than it seems: 142 files changed, 609 insertions(+), 609 deletions(-) The first pass I did was a very quick one, but I already went through the patches I received (apparently not the whole series) and it wasn't that long. I also gave v2 a read-through. Nothing jumped out as a red-flag. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes
2014-03-26 8:44 GMT+01:00 Eric Sunshine sunsh...@sunshineco.com: On Wed, Mar 26, 2014 at 3:02 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Junio C Hamano gits...@pobox.com writes: - Nobody has time or energy to go through 140+ patches in one go, with enough concentration necessary to do so without making mistakes (this applies to yourself, too---producing mechanical replacement is a no-cost thing, finding mistakes in mechanical replacement takes real effort). It's a bit less bad than it seems: 142 files changed, 609 insertions(+), 609 deletions(-) The first pass I did was a very quick one, but I already went through the patches I received (apparently not the whole series) and it wasn't that long. I also gave v2 a read-through. Nothing jumped out as a red-flag. Thank you all. I will change the comment as the maintainer wishes (75ee3d7078fbcc3b87a3ae5e0cf42f46256c5da4 for example) and send the other patches slowly (10 at a time every week, boring but that's okay). Best Regards -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes
This patch series changes everywhere the back-quotes construct for command substitution with the $( ... ). The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes , or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell. Because this construct uses distinct opening and closing delimiters, it is much easier to follow. Also now the embedded double quotes no longer need escaping. The patch is simple but involves a large number of files with different authors. Being simple I think it is wasteful to cc a large number of different people for doing a review. This is a second reroll after the Matthieu Moy review. Changes from v1: - Dropped the silly patches to t6111-rev-list-treesame.sh, t0204-gettext-reencode-sanity.sh. - Simple reformatting of the commit message. - added the toy script used for doing the patch. Elia Pinto (142): check-builtins.sh: use the $( ... ) construct for command substitution git-am.sh: use the $( ... ) construct for command substitution git-pull.sh: use the $( ... ) construct for command substitution git-rebase--merge.sh: use the $( ... ) construct for command substitution git-rebase.sh: use the $( ... ) construct for command substitution git-stash.sh: use the $( ... ) construct for command substitution git-web--browse.sh: use the $( ... ) construct for command substitution unimplemented.sh: use the $( ... ) construct for command substitution t0001-init.sh: use the $( ... ) construct for command substitution t0010-racy-git.sh: use the $( ... ) construct for command substitution t0020-crlf.sh: use the $( ... ) construct for command substitution t0025-crlf-auto.sh: use the $( ... ) construct for command substitution t0026-eol-config.sh: use the $( ... ) construct for command substitution t0030-stripspace.sh: use the $( ... ) construct for command substitution t0300-credentials.sh: use the $( ... ) construct for command substitution t1000-read-tree-m-3way.sh: use the $( ... ) construct for command substitution t1001-read-tree-m-2way.sh: use the $( ... ) construct for command substitution t1002-read-tree-m-u-2way.sh: use the $( ... ) construct for command substitution t1003-read-tree-prefix.sh: use the $( ... ) construct for command substitution t1004-read-tree-m-u-wf.sh: use the $( ... ) construct for command substitution t1020-subdirectory.sh: use the $( ... ) construct for command substitution t1050-large.sh: use the $( ... ) construct for command substitution t1100-commit-tree-options.sh: use the $( ... ) construct for command substitution t1401-symbolic-ref.sh: use the $( ... ) construct for command substitution t1410-reflog.sh: use the $( ... ) construct for command substitution t1511-rev-parse-caret.sh: use the $( ... ) construct for command substitution t1512-rev-parse-disambiguation.sh: use the $( ... ) construct for command substitution t2102-update-index-symlinks.sh: use the $( ... ) construct for command substitution t3030-merge-recursive.sh: use the $( ... ) construct for command substitution t3100-ls-tree-restrict.sh: use the $( ... ) construct for command substitution t3101-ls-tree-dirname.sh: use the $( ... ) construct for command substitution t3210-pack-refs.sh: use the $( ... ) construct for command substitution t3403-rebase-skip.sh: use the $( ... ) construct for command substitution t3511-cherry-pick-x.sh: use the $( ... ) construct for command substitution t3600-rm.sh: use the $( ... ) construct for command substitution t3700-add.sh: use the $( ... ) construct for command substitution t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution t3910-mac-os-precompose.sh: use the $( ... ) construct for command substitution t4006-diff-mode.sh: use the $( ... ) construct for command substitution t4010-diff-pathspec.sh: use the $( ... ) construct for command substitution t4012-diff-binary.sh: use the $( ... ) construct for command substitution t4013-diff-various.sh: use the $( ... ) construct for command substitution t4014-format-patch.sh: use the $( ... ) construct for command substitution t4036-format-patch-signer-mime.sh: use the $( ... ) construct for command substitution t4038-diff-combined.sh: use the $( ... ) construct for command substitution t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitution t4116-apply-reverse.sh: use the $( ... ) construct for command
Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes
Elia Pinto gitter.spi...@gmail.com writes: This is a second reroll after the Matthieu Moy review. Changes from v1: - Dropped the silly patches to t6111-rev-list-treesame.sh, t0204-gettext-reencode-sanity.sh. - Simple reformatting of the commit message. - added the toy script used for doing the patch. In other words, Mattheiu pointed out two examples of breakages and they were the only mistakes after you re-reviewed the mechanical changes, and there is no more? - Cleaning up is a good thing, but - Mechanical and mindless conversion is always error-prone, and - Eyeballing each and every change is required, but - Nobody has time or energy to go through 140+ patches in one go, with enough concentration necessary to do so without making mistakes (this applies to yourself, too---producing mechanical replacement is a no-cost thing, finding mistakes in mechanical replacement takes real effort). That is why we strongly discourage people from such a whole-tree clean-up just for the sake of clean-up and nothing else, and instead encourage them to clean-up as a preparatory step for real work on the files involved. Sure, it would not give us as wide a coverage as a mechanical whole-tree replacement in one-go, but that is the only practical way to avoid mistakes. If it were four patches per every Monday kind of trickle, we might be able to spend some review bandwidth while reviewing other patches, though. So I am not very enthused about reviewing and applying these patches in their current form. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
