Re: [PATCH v2 01/43] refs.c: create a public version of verify_refname_available

2015-10-05 Thread David Turner
On Mon, 2015-10-05 at 06:29 +0200, Michael Haggerty wrote: > + * skip must be sorted. > > + */ > > This comment is approximately a copy of the comment for > verify_refname_available_dir(). It seems unnecessary to keep both of > them (and is also a small maintenance burden). I suggest you shorten

Re: [PATCH v2 01/43] refs.c: create a public version of verify_refname_available

2015-10-04 Thread Michael Haggerty
On 09/29/2015 12:01 AM, David Turner wrote: > From: Ronnie Sahlberg > > Create a public version of verify_refname_available that backends can > provide. > > Signed-off-by: Ronnie Sahlberg > Signed-off-by: David Turner > --- >

Re: [PATCH v2 01/43] refs.c: create a public version of verify_refname_available

2015-10-04 Thread Torsten Bögershausen
On 2015-10-03 18.50, David Turner wrote: > On Sat, 2015-10-03 at 07:02 +0200, Torsten Bögershausen wrote: >> On 29.09.15 00:01, David Turner wrote: >> (Not sure if this is the right thread to report on) >> >> In file included from builtin/commit.c:20: >> ./refs.h:695:16: warning: redefinition of

Re: [PATCH v2 01/43] refs.c: create a public version of verify_refname_available

2015-10-03 Thread David Turner
On Sat, 2015-10-03 at 07:02 +0200, Torsten Bögershausen wrote: > On 29.09.15 00:01, David Turner wrote: > > > (Not sure if this is the right thread to report on) > > In file included from builtin/commit.c:20: > ./refs.h:695:16: warning: redefinition of typedef 'ref_transaction_free_fn' > is a

Re: [PATCH v2 01/43] refs.c: create a public version of verify_refname_available

2015-10-03 Thread Torsten Bögershausen
On 03.10.15 18:50, David Turner wrote: > On Sat, 2015-10-03 at 07:02 +0200, Torsten Bögershausen wrote: >> On 29.09.15 00:01, David Turner wrote: >>> >> (Not sure if this is the right thread to report on) >> >> In file included from builtin/commit.c:20: >> ./refs.h:695:16: warning: redefinition of

Re: [PATCH v2 01/43] refs.c: create a public version of verify_refname_available

2015-10-02 Thread Torsten Bögershausen
On 29.09.15 00:01, David Turner wrote: > (Not sure if this is the right thread to report on) In file included from builtin/commit.c:20: ./refs.h:695:16: warning: redefinition of typedef 'ref_transaction_free_fn' is a C11 feature [-Wtypedef-redefinition] typedef void

[PATCH v2 01/43] refs.c: create a public version of verify_refname_available

2015-09-28 Thread David Turner
From: Ronnie Sahlberg Create a public version of verify_refname_available that backends can provide. Signed-off-by: Ronnie Sahlberg Signed-off-by: David Turner --- refs.c | 51