subject:"\[PATCH v2 03\/94\] builtin\/apply\: avoid parameter shadowing 'linenr' global"

Re: [PATCH v2 03/94] builtin/apply: avoid parameter shadowing 'linenr' global

2016-05-12 Thread Junio C Hamano

Christian Couder writes: > Let's just rename the global 'state_linenr' as it will become > 'state->linenr' in a following patch. > > This also avoid errors when compiling with -Wshadow and makes > it safer to later move global variables into a "state" struct. Looks

[PATCH v2 03/94] builtin/apply: avoid parameter shadowing 'linenr' global

2016-05-11 Thread Christian Couder

Let's just rename the global 'state_linenr' as it will become 'state->linenr' in a following patch. This also avoid errors when compiling with -Wshadow and makes it safer to later move global variables into a "state" struct. Reviewed-by: Stefan Beller Signed-off-by: