Re: [PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

2018-01-17 Thread Оля Тележная
2018-01-18 0:45 GMT+03:00 Jeff King : > On Tue, Jan 16, 2018 at 10:00:42AM +0300, Оля Тележная wrote: > >> > I think some of these will want to remain in cat-file.c. For instance, >> > split_on_whitespace is not something that ref-filter.c itself would care >> > about. I'd expect in

Re: [PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

2018-01-17 Thread Jeff King
On Tue, Jan 16, 2018 at 10:00:42AM +0300, Оля Тележная wrote: > > I think some of these will want to remain in cat-file.c. For instance, > > split_on_whitespace is not something that ref-filter.c itself would care > > about. I'd expect in the endgame for cat-file to keep its own > >

Re: [PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

2018-01-15 Thread Оля Тележная
2018-01-16 0:44 GMT+03:00 Jeff King : > On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > >> Need that for further reusing of formatting logic in cat-file. >> Have plans to get rid of using expand_data in cat-file at all, >> and use it only in ref-filter for

Re: [PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

2018-01-15 Thread Jeff King
On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > Need that for further reusing of formatting logic in cat-file. > Have plans to get rid of using expand_data in cat-file at all, > and use it only in ref-filter for collecting, formatting and printing > needed data. I think some

[PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

2018-01-10 Thread Olga Telezhnaya
Need that for further reusing of formatting logic in cat-file. Have plans to get rid of using expand_data in cat-file at all, and use it only in ref-filter for collecting, formatting and printing needed data. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder