Re: [PATCH v2 04/38] refs: add a backend method structure

[David Turner]

On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote:
> From: Ronnie Sahlberg 
> 
> Add a `struct ref_storage_be` to represent types of reference stores. In
> OO notation, this is the class, and will soon hold some class
> methods (e.g., a factory to create new ref_store instances) and will
> also serve as the vtable for ref_store instances of that type.
> 
> As yet, the backends cannot do anything.
> 
> Signed-off-by: Ronnie Sahlberg 
> Signed-off-by: David Turner 
> Signed-off-by: Junio C Hamano 
> Signed-off-by: Jeff King 
> Signed-off-by: Michael Haggerty 
> Signed-off-by: Junio C Hamano 


nit: duplicate Sign-off from Junio.

[PATCH v2 04/38] refs: add a backend method structure

[Michael Haggerty]

From: Ronnie Sahlberg 

Add a `struct ref_storage_be` to represent types of reference stores. In
OO notation, this is the class, and will soon hold some class
methods (e.g., a factory to create new ref_store instances) and will
also serve as the vtable for ref_store instances of that type.

As yet, the backends cannot do anything.

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: David Turner 
Signed-off-by: Junio C Hamano 
Signed-off-by: Jeff King 
Signed-off-by: Michael Haggerty 
Signed-off-by: Junio C Hamano 
---
 refs.c   | 19 +++
 refs.h   |  2 ++
 refs/files-backend.c |  5 +
 refs/refs-internal.h |  8 
 4 files changed, 34 insertions(+)

diff --git a/refs.c b/refs.c
index 4c609df..d2a29bb 100644
--- a/refs.c
+++ b/refs.c
@@ -10,6 +10,25 @@
 #include "tag.h"
 
 /*
+ * List of all available backends
+ */
+static struct ref_storage_be *refs_backends = _be_files;
+
+static struct ref_storage_be *find_ref_storage_backend(const char *name)
+{
+   struct ref_storage_be *be;
+   for (be = refs_backends; be; be = be->next)
+   if (!strcmp(be->name, name))
+   return be;
+   return NULL;
+}
+
+int ref_storage_backend_exists(const char *name)
+{
+   return find_ref_storage_backend(name) != NULL;
+}
+
+/*
  * How to handle various characters in refnames:
  * 0: An acceptable character for refs
  * 1: End-of-component
diff --git a/refs.h b/refs.h
index 1b02043..9a29f1b 100644
--- a/refs.h
+++ b/refs.h
@@ -544,4 +544,6 @@ int reflog_expire(const char *refname, const unsigned char 
*sha1,
  reflog_expiry_cleanup_fn cleanup_fn,
  void *policy_cb_data);
 
+int ref_storage_backend_exists(const char *name);
+
 #endif /* REFS_H */
diff --git a/refs/files-backend.c b/refs/files-backend.c
index aa09586..ecf66e6 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -4076,3 +4076,8 @@ int reflog_expire(const char *refname, const unsigned 
char *sha1,
unlock_ref(lock);
return -1;
 }
+
+struct ref_storage_be refs_be_files = {
+   NULL,
+   "files"
+};
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index 0206e2b..2c9d134 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -525,4 +525,12 @@ int do_for_each_ref_iterator(struct ref_iterator *iter,
 int read_raw_ref(const char *refname, unsigned char *sha1,
 struct strbuf *referent, unsigned int *type);
 
+/* refs backends */
+struct ref_storage_be {
+   struct ref_storage_be *next;
+   const char *name;
+};
+
+extern struct ref_storage_be refs_be_files;
+
 #endif /* REFS_REFS_INTERNAL_H */
-- 
2.9.3