Re: [PATCH v2 05/17] ls-files: buffer full item in strbuf before printing

On Wed, Mar 26, 2014 at 7:18 PM, Duy Nguyen wrote: > On Thu, Mar 27, 2014 at 2:22 AM, Eric Sunshine > wrote: >>> static void show_dir_entry(const char *tag, struct dir_entry *ent) >>> { >>> + static struct strbuf sb = STRBUF_INIT; >>> int len = max_prefix_len; >>> >>> if

Re: [PATCH v2 05/17] ls-files: buffer full item in strbuf before printing

On Thu, Mar 27, 2014 at 2:22 AM, Eric Sunshine wrote: >> static void show_dir_entry(const char *tag, struct dir_entry *ent) >> { >> + static struct strbuf sb = STRBUF_INIT; >> int len = max_prefix_len; >> >> if (len >= ent->len) >> @@ -67,8 +79,10 @@ static void show_dir_en

Re: [PATCH v2 05/17] ls-files: buffer full item in strbuf before printing

On Wed, Mar 26, 2014 at 9:48 AM, Nguyễn Thái Ngọc Duy wrote: > Buffering so that we can manipulate the strings (e.g. coloring) > further before finally printing them. > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/ls-files.c | 48 +++- > 1 fil

[PATCH v2 05/17] ls-files: buffer full item in strbuf before printing

Buffering so that we can manipulate the strings (e.g. coloring) further before finally printing them. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/ls-files.c | 48 +++- 1 file changed, 35 insertions(+), 13 deletions(-) diff --git a/builtin/ls-files