Re: [PATCH v2 1/2] commit-slabs: move MAYBE_UNUSED out

2018-10-23 Thread Carlo Arenas
On Tue, Oct 23, 2018 at 3:00 PM Jeff King wrote: > On Tue, Oct 23, 2018 at 02:50:19PM -0700, Carlo Marcelo Arenas Belón wrote: > > #define implement_static_commit_slab(slabname, elemtype) \ > > - implement_commit_slab(slabname, elemtype, static MAYBE_UNUSED) > > +

Re: [PATCH v2 1/2] commit-slabs: move MAYBE_UNUSED out

2018-10-23 Thread Jeff King
On Tue, Oct 23, 2018 at 02:50:19PM -0700, Carlo Marcelo Arenas Belón wrote: > after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18) > it is expected to be used to prevent -Wunused-function warnings for code > that was macro generated Makes sense. > diff --git

[PATCH v2 1/2] commit-slabs: move MAYBE_UNUSED out

2018-10-23 Thread Carlo Marcelo Arenas Belón
after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18) it is expected to be used to prevent -Wunused-function warnings for code that was macro generated Signed-off-by: Carlo Marcelo Arenas Belón --- commit-slab-impl.h | 4 ++-- git-compat-util.h | 2 ++ 2 files changed, 4