Re: [PATCH v2 1/6] t/send-email.sh: add test for suppress-cc=self

2013-06-03 Thread Junio C Hamano 
Michael S. Tsirkin m...@redhat.com writes:

 This adds a basic test for --suppress-cc=self
 option of git send-email.

 Signed-off-by: Michael S. Tsirkin m...@redhat.com
 ---
  t/t9001-send-email.sh | 43 +++
  1 file changed, 43 insertions(+)

 diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
 index ebd5c5d..e1a7f3e 100755
 --- a/t/t9001-send-email.sh
 +++ b/t/t9001-send-email.sh
 @@ -171,6 +171,49 @@ Result: OK
  EOF
  
  
 +test_suppress_self () {
 + test_commit $3 
 + test_when_finished git reset --hard HEAD^ 
 +
 + write_script cccmd-sed -EOF 
 + sed -n -e s/^cccmd--//p \$1
 + EOF
 +
 + git commit --amend --author=$1 $2 -F -   

Ahh, this helper reads the log message from its standard input;
nice.

 + clean_fake_sendmail   
 + git format-patch --stdout -1 suppress-self-$3.patch   
 +
 + git send-email --from=$1 $2 \
 + --to=nob...@example.com \
 + --cc-cmd=./cccmd-sed \
 + --suppress-cc=self \
 + --smtp-server=$(pwd)/fake.sendmail \
 + suppress-self-$3.patch 
 +
 + mv msgtxt1 msgtxt1-$3 
 + sed -e '/^$/q' msgtxt1-$3 msghdr1-$3 
 + expected-no-cc-$3 
 +
 + (grep '^Cc:' msghdr1-$3 actual-no-cc-$3;
 +  test_cmp expected-no-cc-$3 actual-no-cc-$3)
 +}
 +
 +test_suppress_self_unquoted () {
 + test_suppress_self $1 $2 unquoted-$3 -EOF
 + test suppress-cc.self unquoted-$3 with name $1 email $2
 +
 + unquoted-$3
 +
 + Cc: $1 $2
 + Signed-off-by: $1 $2
 + EOF
 +}
 +
 +test_expect_success $PREREQ 'self name is suppressed' 
 + test_suppress_self_unquoted 'A U Thor' 'aut...@redhat.com' \
 + 'self_name_suppressed'
 +
 +
  test_expect_success $PREREQ 'Show all headers' '
   git send-email \
   --dry-run \
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/6] t/send-email.sh: add test for suppress-cc=self

2013-05-30 Thread Michael S. Tsirkin 
This adds a basic test for --suppress-cc=self
option of git send-email.

Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
 t/t9001-send-email.sh | 43 +++
 1 file changed, 43 insertions(+)

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index ebd5c5d..e1a7f3e 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -171,6 +171,49 @@ Result: OK
 EOF
 
 
+test_suppress_self () {
+   test_commit $3 
+   test_when_finished git reset --hard HEAD^ 
+
+   write_script cccmd-sed -EOF 
+   sed -n -e s/^cccmd--//p \$1
+   EOF
+
+   git commit --amend --author=$1 $2 -F -   
+   clean_fake_sendmail   
+   git format-patch --stdout -1 suppress-self-$3.patch   
+
+   git send-email --from=$1 $2 \
+   --to=nob...@example.com \
+   --cc-cmd=./cccmd-sed \
+   --suppress-cc=self \
+   --smtp-server=$(pwd)/fake.sendmail \
+   suppress-self-$3.patch 
+
+   mv msgtxt1 msgtxt1-$3 
+   sed -e '/^$/q' msgtxt1-$3 msghdr1-$3 
+   expected-no-cc-$3 
+
+   (grep '^Cc:' msghdr1-$3 actual-no-cc-$3;
+test_cmp expected-no-cc-$3 actual-no-cc-$3)
+}
+
+test_suppress_self_unquoted () {
+   test_suppress_self $1 $2 unquoted-$3 -EOF
+   test suppress-cc.self unquoted-$3 with name $1 email $2
+
+   unquoted-$3
+
+   Cc: $1 $2
+   Signed-off-by: $1 $2
+   EOF
+}
+
+test_expect_success $PREREQ 'self name is suppressed' 
+   test_suppress_self_unquoted 'A U Thor' 'aut...@redhat.com' \
+   'self_name_suppressed'
+
+
 test_expect_success $PREREQ 'Show all headers' '
git send-email \
--dry-run \
-- 
MST

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html