Re: [PATCH v2 15/25] object_array_entry: fix memory handling of the name field

2013-05-29 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: Change the callers that were already passing copies to add_object_array_with_mode() to either skip the copy, or (if the memory needed to be allocated anyway) freeing the memory itself. A part of this commit effectively reverts 70d26c6e76

[PATCH v2 15/25] object_array_entry: fix memory handling of the name field

2013-05-25 Thread Michael Haggerty
Previously, the memory management of the object_array_entry::name field was inconsistent and undocumented. object_array_entries are ultimately created by a single function, add_object_array_with_mode(), which has an argument const char *name. This function used to simply set the name field to