Re: [PATCH v2 2/2] blame: use different blame_date_width for different locale

2014-04-22 Thread David Kastrup
Junio C Hamano gits...@pobox.com writes: This is not wrong per-se, but I am not sure if translators would understand that years and months ago may not be the longuest variant for their language and they are asked to use 89 seconds ago if the translation of that is longer than the translation

Re: [PATCH v2 2/2] blame: use different blame_date_width for different locale

2014-04-22 Thread Jiang Xin
2014-04-22 18:01 GMT+08:00 David Kastrup d...@gnu.org: Junio C Hamano gits...@pobox.com writes: This is not wrong per-se, but I am not sure if translators would understand that years and months ago may not be the longuest variant for their language and they are asked to use 89 seconds ago if

[PATCH v2 2/2] blame: use different blame_date_width for different locale

2014-04-20 Thread Jiang Xin
When show date in relative date format for `git blame`, the max display width of datetime is set as the length of the string Thu Oct 19 16:00:04 2006 -0700 (30 characters long). But actually the max width for C locale is only 22 (the length of string x years, xx months ago). And for other locale,

Re: [PATCH v2 2/2] blame: use different blame_date_width for different locale

2014-04-20 Thread Junio C Hamano
Jiang Xin worldhello@gmail.com writes: When show date in relative date format for `git blame`, the max display width of datetime is set as the length of the string Thu Oct 19 16:00:04 2006 -0700 (30 characters long). But actually the max width for C locale is only 22 (the length of