Re: [PATCH v2 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-17 Thread Michael Haggerty
On 11/16/2014 09:06 AM, Johannes Sixt wrote: Am 16.11.2014 um 08:21 schrieb Michael Haggerty: @@ -559,9 +562,21 @@ int cmd_config(int argc, const char **argv, const char *prefix) if (given_config_source.blob) die(editing blobs is not supported);

Re: [PATCH v2 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-16 Thread Johannes Sixt
Am 16.11.2014 um 08:21 schrieb Michael Haggerty: @@ -559,9 +562,21 @@ int cmd_config(int argc, const char **argv, const char *prefix) if (given_config_source.blob) die(editing blobs is not supported); git_config(git_default_config, NULL); -

[PATCH v2 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

2014-11-15 Thread Michael Haggerty
There is no reason for $GIT_DIR/config to be executable, plus there used to be a bug (fixed by the previous commit) that caused git init to set the u+x bit on that file. So whenever rewriting the config file, take the opportunity to remove any executable bits that the file might have.