Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-21 Thread Junio C Hamano
Ben Peart writes: > On 10/19/2018 1:11 PM, Jeff King wrote: >> On Fri, Oct 19, 2018 at 01:10:34PM -0400, Eric Sunshine wrote: >> >>> On Fri, Oct 19, 2018 at 12:46 PM Jeff King wrote: On Fri, Oct 19, 2018 at 12:36:44PM -0400, Eric Sunshine wrote: > How does the user reverse this for a

Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Jeff King
On Fri, Oct 19, 2018 at 01:23:06PM -0400, Ben Peart wrote: > > > Okay. In any case, --no-quiet probably ought to be mentioned alongside > > > the "reset.quiet" option (and perhaps in git-reset.txt to as a way to > > > reverse "reset.quiet"). > [...] > Makes sense. I'll update the docs to say: >

Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Ben Peart
On 10/19/2018 1:11 PM, Jeff King wrote: On Fri, Oct 19, 2018 at 01:10:34PM -0400, Eric Sunshine wrote: On Fri, Oct 19, 2018 at 12:46 PM Jeff King wrote: On Fri, Oct 19, 2018 at 12:36:44PM -0400, Eric Sunshine wrote: How does the user reverse this for a particular git-reset invocation?

Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Ben Peart
On 10/19/2018 12:46 PM, Jeff King wrote: On Fri, Oct 19, 2018 at 12:36:44PM -0400, Eric Sunshine wrote: On Fri, Oct 19, 2018 at 12:12 PM Ben Peart wrote: Add a reset.quiet config setting that sets the default value of the --quiet flag when running the reset command. This enables users to

Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Jeff King
On Fri, Oct 19, 2018 at 01:10:34PM -0400, Eric Sunshine wrote: > On Fri, Oct 19, 2018 at 12:46 PM Jeff King wrote: > > On Fri, Oct 19, 2018 at 12:36:44PM -0400, Eric Sunshine wrote: > > > How does the user reverse this for a particular git-reset invocation? > > > There is no --no-quiet or

Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Eric Sunshine
On Fri, Oct 19, 2018 at 12:46 PM Jeff King wrote: > On Fri, Oct 19, 2018 at 12:36:44PM -0400, Eric Sunshine wrote: > > How does the user reverse this for a particular git-reset invocation? > > There is no --no-quiet or --verbose option. > > > > Perhaps you want to use OPT__VERBOSITY() instead of

Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Jeff King
On Fri, Oct 19, 2018 at 12:36:44PM -0400, Eric Sunshine wrote: > On Fri, Oct 19, 2018 at 12:12 PM Ben Peart wrote: > > Add a reset.quiet config setting that sets the default value of the --quiet > > flag when running the reset command. This enables users to change the > > default behavior to

Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Eric Sunshine
On Fri, Oct 19, 2018 at 12:12 PM Ben Peart wrote: > Add a reset.quiet config setting that sets the default value of the --quiet > flag when running the reset command. This enables users to change the > default behavior to take advantage of the performance advantages of > avoiding the scan for

[PATCH v2 2/3] reset: add new reset.quiet config setting

2018-10-19 Thread Ben Peart
From: Ben Peart Add a reset.quiet config setting that sets the default value of the --quiet flag when running the reset command. This enables users to change the default behavior to take advantage of the performance advantages of avoiding the scan for unstaged changes after reset. Defaults to