Re: [PATCH v2 2/3] sequencer: make commit options more extensible

Hi Junio, On Mon, 27 Mar 2017, Junio C Hamano wrote: > Junio C Hamano writes: > > > As this thing is about fixing a regression visible to end users, I > > may get around to fixing things up myself, but I have other topics > > to attend to, so... > > So I ended up with this

Re: [PATCH v2 2/3] sequencer: make commit options more extensible

Junio C Hamano writes: > As this thing is about fixing a regression visible to end users, I > may get around to fixing things up myself, but I have other topics > to attend to, so... So I ended up with this version before merging it to 'next'. I moved 'allow' back on the

Re: [PATCH v2 2/3] sequencer: make commit options more extensible

Johannes Schindelin writes: >> Making "flags" unsigned was a correct change, but this is now wrong, >> as "allow" is made unsigned by accident. > ... > > Your patch looks good, you could do even better by reverting that move > (IIRC it was at the end of the line, and

Re: [PATCH v2 2/3] sequencer: make commit options more extensible

Hi Junio, On Thu, 23 Mar 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > @@ -926,14 +930,14 @@ static void record_in_rewritten(struct object_id *oid, > > static int do_pick_commit(enum todo_command command, struct commit *commit, > >

Re: [PATCH v2 2/3] sequencer: make commit options more extensible

Johannes Schindelin writes: > @@ -926,14 +930,14 @@ static void record_in_rewritten(struct object_id *oid, > static int do_pick_commit(enum todo_command command, struct commit *commit, > struct replay_opts *opts, int final_fixup) > { > - int edit =

[PATCH v2 2/3] sequencer: make commit options more extensible

It was pointed out during review of the sequencer-i patch series (which taught the sequencer to execute an interactive rebase) that it may be cumbersome to keep extending the signature of the run_git_commit() function whenever a new commit option is needed. While that concern had merit, back then