Re: [PATCH v2 2/4] t7610: make tests more independent and debuggable

2017-01-06 Thread Richard Hansen
On 2017-01-05 20:31, Stefan Beller wrote: On Thu, Jan 5, 2017 at 5:09 PM, Richard Hansen wrote: Reduce how much a test can interfere other tests: A bullet point list as an unordered list often indicates that you're doing multiple things at once, possibly unrelated, so

Re: [PATCH v2 2/4] t7610: make tests more independent and debuggable

2017-01-05 Thread Stefan Beller
On Thu, Jan 5, 2017 at 5:09 PM, Richard Hansen wrote: > Reduce how much a test can interfere other tests: A bullet point list as an unordered list often indicates that you're doing multiple things at once, possibly unrelated, so they could go into different patches. ;) While

[PATCH v2 2/4] t7610: make tests more independent and debuggable

2017-01-05 Thread Richard Hansen
Reduce how much a test can interfere other tests: * Move setup code that multiple tests depend on to the 'setup' test case. * Run 'git reset --hard' after every test (pass or fail) to clean up in case the test fails and leaves the repository in a strange state. * If the