Re: [PATCH v2 2/5] repack: add --keep-pack option

2018-03-07 Thread Duy Nguyen
On Wed, Mar 7, 2018 at 1:25 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> +--keep-pack=:: >> + Ignore the given pack. This is the equivalent of having >> + `.keep` file on the pack. Implies `--honor-pack-keep`. >> + > > A few

Re: [PATCH v2 2/5] repack: add --keep-pack option

2018-03-06 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > +--keep-pack=:: > + Ignore the given pack. This is the equivalent of having > + `.keep` file on the pack. Implies `--honor-pack-keep`. > + A few questions I am not sure how I would answer: - Do we want to have this listed in the

[PATCH v2 2/5] repack: add --keep-pack option

2018-03-06 Thread Nguyễn Thái Ngọc Duy
We allow to keep existing packs by having companion .keep files. This is helpful when a pack is permanently kept. In the next patch, git-gc just wants to keep a pack temporarily, for one pack-objects run. git-gc can use --keep-pack for this use case. Signed-off-by: Nguyễn Thái Ngọc Duy