Re: [PATCH v2 3/3] diff: Introduce --diff-algorithm command line option

2013-01-15 Thread Michal Privoznik
On 14.01.2013 22:06, Junio C Hamano wrote: > Michal Privoznik writes: > >> +--diff-algorithm={patience|minimal|histogram|myers}:: >> +Choose a diff algorithm. The variants are as follows: >> ++ >> +-- >> +`myers`;; >> +The basic greedy diff algorithm. >> +`minimal`;; >> +Spend extra t

Re: [PATCH v2 3/3] diff: Introduce --diff-algorithm command line option

2013-01-14 Thread Junio C Hamano
Michal Privoznik writes: > +--diff-algorithm={patience|minimal|histogram|myers}:: > + Choose a diff algorithm. The variants are as follows: > ++ > +-- > +`myers`;; > + The basic greedy diff algorithm. > +`minimal`;; > + Spend extra time to make sure the smallest possible diff is > +

[PATCH v2 3/3] diff: Introduce --diff-algorithm command line option

2013-01-14 Thread Michal Privoznik
Since command line options have higher priority than config file variables and taking previous commit into account, we need a way how to specify myers algorithm on command line. However, inventing `--myers` is not the right answer. We need far more general option, and that is `--diff-algorithm`. S