Re: [PATCH v2 3/5] rev-list: handle missing tree objects properly

2018-08-14 Thread Jonathan Tan
> I don't understand about the ">= 0". What should I replace it with? > Maybe you mean the return is never positive so I can change: > > parse_tree_gently(tree, 1) >= 0 > > to: > !parse_tree_gently(tree, 1) > > ? Sorry for the lack of clarity - that is what I meant. > > The missing mechanism

Re: [PATCH v2 3/5] rev-list: handle missing tree objects properly

2018-08-13 Thread Matthew DeVore
Resending this in plain-text mode so that git@vger.kernel.org won't bounce it. Sorry for those of you receiving this twice. On Mon, Aug 13, 2018 at 11:20 AM Jonathan Tan wrote: > > > In list-objects.c we no longer print a message to stderr if a tree > > object is missing (quiet_on_missing is

Re: [PATCH v2 3/5] rev-list: handle missing tree objects properly

2018-08-13 Thread Jonathan Tan
> In list-objects.c we no longer print a message to stderr if a tree > object is missing (quiet_on_missing is always true). I couldn't find > any place where this would matter, or where the caller of > traverse_commit_list would need to be fixed to show the error. However, > in the future it would

[PATCH v2 3/5] rev-list: handle missing tree objects properly

2018-08-10 Thread Matthew DeVore
Previously, we assumed only blob objects could be missing. This patch makes rev-list handle missing trees like missing blobs. A missing tree will cause an error if --missing indicates an error should be caused, and the hash is printed even if the tree is missing. In list-objects.c we no longer