Re: [PATCH v2 4/8] cherry-pick: store rewritten commits

2013-06-03 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes:

 +static void add_rewritten(unsigned char *from, unsigned char *to)
 +{
 + struct rewritten_list_item *item;
 + if (rewritten.nr + 1 = rewritten.alloc) {
 + rewritten.alloc += 32;
 + rewritten.items = xrealloc(rewritten.items, rewritten.alloc * 
 sizeof(*rewritten.items));
 + }

Is there a compelling reason not to use ALLOC_GROW() here?

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 4/8] cherry-pick: store rewritten commits

2013-06-03 Thread Felipe Contreras
On Mon, Jun 3, 2013 at 1:49 PM, Junio C Hamano gits...@pobox.com wrote:
 Felipe Contreras felipe.contre...@gmail.com writes:

 +static void add_rewritten(unsigned char *from, unsigned char *to)
 +{
 + struct rewritten_list_item *item;
 + if (rewritten.nr + 1 = rewritten.alloc) {
 + rewritten.alloc += 32;
 + rewritten.items = xrealloc(rewritten.items, rewritten.alloc * 
 sizeof(*rewritten.items));
 + }

 Is there a compelling reason not to use ALLOC_GROW() here?

Nope, I just copied the logic from another part of Git.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 4/8] cherry-pick: store rewritten commits

2013-05-28 Thread Felipe Contreras
Will be useful for the next commits.

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
 sequencer.c | 95 -
 sequencer.h |  1 +
 2 files changed, 95 insertions(+), 1 deletion(-)

diff --git a/sequencer.c b/sequencer.c
index d3c7d72..c217716 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -20,6 +20,18 @@
 const char sign_off_header[] = Signed-off-by: ;
 static const char cherry_picked_prefix[] = (cherry picked from commit ;
 
+struct rewritten_list_item {
+   unsigned char from[20];
+   unsigned char to[20];
+};
+
+struct rewritten_list {
+   struct rewritten_list_item *items;
+   unsigned int nr, alloc;
+};
+
+static struct rewritten_list rewritten;
+
 static int is_rfc2822_line(const char *buf, int len)
 {
int i;
@@ -102,6 +114,19 @@ static int has_conforming_footer(struct strbuf *sb, struct 
strbuf *sob,
return 1;
 }
 
+static void add_rewritten(unsigned char *from, unsigned char *to)
+{
+   struct rewritten_list_item *item;
+   if (rewritten.nr + 1 = rewritten.alloc) {
+   rewritten.alloc += 32;
+   rewritten.items = xrealloc(rewritten.items, rewritten.alloc * 
sizeof(*rewritten.items));
+   }
+   item = rewritten.items[rewritten.nr];
+   hashcpy(item-from, from);
+   hashcpy(item-to, to);
+   rewritten.nr++;
+}
+
 static void remove_sequencer_state(void)
 {
struct strbuf seq_dir = STRBUF_INIT;
@@ -641,6 +666,14 @@ static int do_pick_commit(struct commit *commit, struct 
replay_opts *opts)
if (!opts-no_commit)
res = run_git_commit(defmsg, opts, allow);
 
+   if (!res) {
+   unsigned char to[20];
+
+   if (read_ref(HEAD, to))
+   goto leave;
+
+   add_rewritten(commit-object.sha1, to);
+   }
 leave:
free_message(msg);
free(defmsg);
@@ -786,6 +819,40 @@ static void read_populate_todo(struct commit_list 
**todo_list,
die(_(Unusable instruction sheet: %s), todo_file);
 }
 
+static void read_populate_rewritten(void)
+{
+   const char *rewritten_file = git_path(SEQ_REWR_FILE);
+   struct strbuf buf = STRBUF_INIT;
+   char *p;
+   int fd;
+
+   fd = open(rewritten_file, O_RDONLY);
+   if (fd  0)
+   return;
+   if (strbuf_read(buf, fd, 0)  0) {
+   close(fd);
+   strbuf_release(buf);
+   return;
+   }
+   close(fd);
+
+   for (p = buf.buf; *p;) {
+   unsigned char from[20];
+   unsigned char to[20];
+   char *eol = strchrnul(p, '\n');
+   if (eol - p != 81)
+   /* wrong size */
+   break;
+   if (get_sha1_hex(p, from))
+   break;
+   if (get_sha1_hex(p + 41, to))
+   break;
+   add_rewritten(from, to);
+   p = *eol ? eol + 1 : eol;
+   }
+   strbuf_release(buf);
+}
+
 static int populate_opts_cb(const char *key, const char *value, void *data)
 {
struct replay_opts *opts = data;
@@ -958,6 +1025,29 @@ static void save_todo(struct commit_list *todo_list, 
struct replay_opts *opts)
strbuf_release(buf);
 }
 
+static void save_rewritten(void)
+{
+   const char *todo_file = git_path(SEQ_REWR_FILE);
+   static struct lock_file rewritten_lock;
+   struct strbuf buf = STRBUF_INIT;
+   int fd, i;
+
+   fd = hold_lock_file_for_update(rewritten_lock, todo_file, 
LOCK_DIE_ON_ERROR);
+   for (i = 0; i  rewritten.nr; i++) {
+   struct rewritten_list_item *item = rewritten.items[i];
+   strbuf_addf(buf, %s %s\n, sha1_to_hex(item-from), 
sha1_to_hex(item-to));
+   }
+   if (write_in_full(fd, buf.buf, buf.len)  0) {
+   strbuf_release(buf);
+   die_errno(_(Could not write to %s), todo_file);
+   }
+   if (commit_lock_file(rewritten_lock)  0) {
+   strbuf_release(buf);
+   die(_(Error wrapping up %s.), todo_file);
+   }
+   strbuf_release(buf);
+}
+
 static void save_opts(struct replay_opts *opts)
 {
const char *opts_file = git_path(SEQ_OPTS_FILE);
@@ -1003,8 +1093,10 @@ static int pick_commits(struct commit_list *todo_list, 
struct replay_opts *opts)
for (cur = todo_list; cur; cur = cur-next) {
save_todo(cur, opts);
res = do_pick_commit(cur-item, opts);
-   if (res)
+   if (res) {
+   save_rewritten();
return res;
+   }
}
 
/*
@@ -1033,6 +1125,7 @@ static int sequencer_continue(struct replay_opts *opts)
return continue_single_pick();
read_populate_opts(opts);
read_populate_todo(todo_list, opts);
+   read_populate_rewritten();
 
/* Verify that the conflict has been