[PATCH v3] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Tanay Abhra
In record_author_date() parse_gpg_output() ,using skip_prefix() instead of starts_with() is a more suitable abstraction. Helped-by: Max Horn m...@quendi.de Helped-by: Junio C Hamano gits...@pobox.com Helped-by: Michael Haggerty mhag...@alum.mit.edu Signed-off-by: Tanay Abhra tanay...@gmail.com

Re: [PATCH v3] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Max Horn
On 04.03.2014, at 09:42, Tanay Abhra tanay...@gmail.com wrote: [...] commit.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/commit.c b/commit.c index 6bf4fe0..6c92acb 100644 --- a/commit.c +++ b/commit.c [...] @@ -566,14 +566,16 @@ static void

Re: [PATCH v3] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Junio C Hamano
Tanay Abhra tanay...@gmail.com writes: In record_author_date() parse_gpg_output() ,using skip_prefix() instead of starts_with() is a more suitable abstraction. Thanks. Will queue with a reworded message to clarify what exactly A more suitable means. Here is what I tentatively came up with.

Re: [PATCH v3] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Junio C Hamano
Max Horn m...@quendi.de writes: +buf = ident_line; if (split_ident_line(ident, - buf + strlen(author ), - line_end - (buf + strlen(author ))) || + buf, +