On Thu, Oct 18, 2012 at 02:16:11PM -0700, Junio C Hamano wrote:
> I guess combining both is fine, but then the commit is no longer "in
> preparation for adding" the option, but it already adds "--long", I
> would think.
Maybe a better commit message is:
-- >8 --
Subject: status: add --long outpu
Nguyễn Thái Ngọc Duy writes:
> From: Jeff King
>
> When deciding which output format to use, we default an internal enum
> to STATUS_FORMAT_LONG and modify it if "--porcelain" or "--short" is
> given. If this enum is set to LONG, then we know the user has not
> specified any format, and we can
On Thu, Oct 18, 2012 at 09:15:50PM +0700, Nguyen Thai Ngoc Duy wrote:
> On Thu, Oct 18, 2012 at 9:03 AM, Jeff King wrote:
> > I think that is fine to split it like this, but you would want to update
> > the commit message above. Probably just remove those two cases and say
> > something like:
From: Jeff King
When deciding which output format to use, we default an internal enum
to STATUS_FORMAT_LONG and modify it if "--porcelain" or "--short" is
given. If this enum is set to LONG, then we know the user has not
specified any format, and we can kick in default behaviors. This works
becau
4 matches
Mail list logo
