Hi all,
Attached is 'v3' of my patch series to add a `--default` option to `git config`.
The most notable change since the last reroll is that this series is now based
upon tb/config-type-specifier-option [1], with discussion about that change here
[2]. This was motivated by my and Peff's shared concern that by adding `--color`
as a top-level type specifier, that we'd be "squatting" on adding `--color` in
the traditional sense of "colorize this output."
As such, `--color` is _not_ added as a top-level type specifier in this version,
rather, it is accessible via `--type=color`. This leaves `--color` unused and
available for other uses in the future.
Other changes since last time include:
1. Fixing an erroneous diff in Documentation/git-config.txt, where a header
was removed.
2. `git config` will now die immediately when the `--default` value is not
canonicalize able under the given type specifier.
3. Removing redundancies from t1300 and t1310 that are--as Peff wisely points
out--unlikely to catch any meaningful regressions in the future.
4. Documenting behavior in builtin/config.c that we "throw away" the
canonicalized value during normalization.
As always, thank you for the helpful feedback. I look forward to your thoughts
on this version of the series.
Thanks,
Taylor
Taylor Blau (3):
builtin/config: introduce `--default`
config.c: introduce 'git_config_color' to parse ANSI colors
builtin/config: introduce `color` type specifier
Documentation/git-config.txt | 15 ++
builtin/config.c | 38
config.c | 10 ++
config.h | 1 +
t/t1300-repo-config.sh | 30
t/t1310-config-default.sh| 38
6 files changed, 128 insertions(+), 4 deletions(-)
create mode 100755 t/t1310-config-default.sh
--
2.16.2.440.gc6284da4f
