Re: [PATCH v3 0/6] git_config callers rewritten with the new config cache API

2014-07-21 Thread Matthieu Moy
Tanay Abhra writes: > On 7/21/2014 7:15 PM, Matthieu Moy wrote: >> Tanay Abhra writes: >> >>> On 7/21/2014 6:21 PM, Matthieu Moy wrote: 2) Add a by-address parameter to git_configset_get_value that allows the user to get the file and line information. In your previous patch,

Re: [PATCH v3 0/6] git_config callers rewritten with the new config cache API

2014-07-21 Thread Tanay Abhra
On 7/21/2014 7:15 PM, Matthieu Moy wrote: > Tanay Abhra writes: > >> On 7/21/2014 6:21 PM, Matthieu Moy wrote: >>> 2) Add a by-address parameter to git_configset_get_value that allows the >>>user to get the file and line information. In your previous patch, >>>that would mean returning

Re: [PATCH v3 0/6] git_config callers rewritten with the new config cache API

2014-07-21 Thread Matthieu Moy
Tanay Abhra writes: > On 7/21/2014 6:21 PM, Matthieu Moy wrote: >> 2) Add a by-address parameter to git_configset_get_value that allows the >>user to get the file and line information. In your previous patch, >>that would mean returning a pointer to the corresponding struct >>key_sour

Re: [PATCH v3 0/6] git_config callers rewritten with the new config cache API

2014-07-21 Thread Tanay Abhra
On 7/21/2014 6:21 PM, Matthieu Moy wrote: > Tanay Abhra writes: > >> [PATCH v3]: Most of Eric's suggestions has been implemented. See [2] for >> discussion. >> Also, new helpers introduced in v7 of the config-set API series have >> been used. >> See [1] for the documentation of the

Re: [PATCH v3 0/6] git_config callers rewritten with the new config cache API

2014-07-21 Thread Matthieu Moy
Tanay Abhra writes: > [PATCH v3]: Most of Eric's suggestions has been implemented. See [2] for > discussion. > Also, new helpers introduced in v7 of the config-set API series have > been used. > See [1] for the documentation of the new functions. > > This series builds on the top of

[PATCH v3 0/6] git_config callers rewritten with the new config cache API

2014-07-21 Thread Tanay Abhra
[PATCH v3]: Most of Eric's suggestions has been implemented. See [2] for discussion. Also, new helpers introduced in v7 of the config-set API series have been used. See [1] for the documentation of the new functions. This series builds on the top of 5def4132 in pu or topic[1] in