Re: [PATCH v3 0/7] tag: only respect `pager.tag` in list-mode

2017-08-03 Thread Jeff King
On Fri, Aug 04, 2017 at 06:21:47AM +0200, Martin Ågren wrote: > On 3 August 2017 at 21:29, Jeff King wrote: > > On Wed, Aug 02, 2017 at 09:40:48PM +0200, Martin Ågren wrote: > > > >> This is the third version of my attempt to make `pager tag` useful (v1 > >> at [1], v2 at [2]). Thanks to Junio an

Re: [PATCH v3 0/7] tag: only respect `pager.tag` in list-mode

2017-08-03 Thread Martin Ågren
On 3 August 2017 at 21:29, Jeff King wrote: > On Wed, Aug 02, 2017 at 09:40:48PM +0200, Martin Ågren wrote: > >> This is the third version of my attempt to make `pager tag` useful (v1 >> at [1], v2 at [2]). Thanks to Junio and Peff for comments on v2. > > This looks good to me overall. One minor q

Re: [PATCH v3 0/7] tag: only respect `pager.tag` in list-mode

2017-08-03 Thread Jeff King
On Wed, Aug 02, 2017 at 09:40:48PM +0200, Martin Ågren wrote: > This is the third version of my attempt to make `pager tag` useful (v1 > at [1], v2 at [2]). Thanks to Junio and Peff for comments on v2. This looks good to me overall. One minor question from the interdiff: > diff --git a/t/t7006-p

Re: [PATCH v3 0/7] tag: only respect `pager.tag` in list-mode

2017-08-03 Thread Junio C Hamano
Martin Ågren writes: > This is the third version of my attempt to make `pager tag` useful (v1 > at [1], v2 at [2]). Thanks to Junio and Peff for comments on v2. > > I've squashed patches 01-03/10 and 07-08/10, respectively. The interdiff > is below. I managed to clean up some tests thanks to a dr

[PATCH v3 0/7] tag: only respect `pager.tag` in list-mode

2017-08-02 Thread Martin Ågren
This is the third version of my attempt to make `pager tag` useful (v1 at [1], v2 at [2]). Thanks to Junio and Peff for comments on v2. I've squashed patches 01-03/10 and 07-08/10, respectively. The interdiff is below. I managed to clean up some tests thanks to a drive-by comment by Peff which cle