Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-17 Thread Michael Haggerty
On 09/11/2012 12:10 AM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: OK. As long as the sort order matches the order string-list internally uses for its bisection search, it won't be a problem, then. The sorting is crucial but there is no bisection involved. The

Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-10 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: This patch series depends on the Add some string_list-related functions series that I just submitted. This series is a significant rewrite of v2 based on the realization that the nr_heads,heads pair that is passed around in these functions is

Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-10 Thread Michael Haggerty
On 09/09/2012 08:15 PM, Junio C Hamano wrote: Jeff King p...@peff.net writes: On Sun, Sep 09, 2012 at 03:20:18AM -0700, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: This patch series depends on the Add some string_list-related functions series that I just submitted.

Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-10 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: OK. As long as the sort order matches the order string-list internally uses for its bisection search, it won't be a problem, then. The sorting is crucial but there is no bisection involved. The sorted linked-list of references available from

[PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-09 Thread Michael Haggerty
This patch series depends on the Add some string_list-related functions series that I just submitted. This series is a significant rewrite of v2 based on the realization that the nr_heads,heads pair that is passed around in these functions is better expressed as a string_list. I hope you will

Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-09 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: This patch series depends on the Add some string_list-related functions series that I just submitted. Makes sense. The only worry (without reading the series first) I have is that the use of string list may make the responsiblity of sorting the

Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-09 Thread Jeff King
On Sun, Sep 09, 2012 at 03:20:18AM -0700, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: This patch series depends on the Add some string_list-related functions series that I just submitted. Makes sense. The only worry (without reading the series first) I have is

Re: [PATCH v3 00/14] Clean up how fetch_pack() handles the heads list

2012-09-09 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sun, Sep 09, 2012 at 03:20:18AM -0700, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: This patch series depends on the Add some string_list-related functions series that I just submitted. Makes sense. The only worry (without