Re: [PATCH v3 00/14] Some fixes and bunch of object_id conversions

On Wed, Jan 24, 2018 at 01:41:07PM -0800, Junio C Hamano wrote: > Patryk Obara writes: > > > Patryk Obara (14): > > http-push: improve error log > > clang-format: adjust penalty for return type line break > > sha1_file: convert pretend_sha1_file to object_id > >

Re: [PATCH v3 00/14] Some fixes and bunch of object_id conversions

On Thu, Jan 25, 2018 at 4:41 AM, Junio C Hamano wrote: > Patryk Obara writes: > >> Patryk Obara (14): >> http-push: improve error log >> clang-format: adjust penalty for return type line break >> sha1_file: convert pretend_sha1_file to object_id

Re: [PATCH v3 00/14] Some fixes and bunch of object_id conversions

Patryk Obara writes: > Patryk Obara (14): > http-push: improve error log > clang-format: adjust penalty for return type line break > sha1_file: convert pretend_sha1_file to object_id > dir: convert struct sha1_stat to use object_id > sha1_file: convert

Re: [PATCH v3 00/14] Some fixes and bunch of object_id conversions

Patryk Obara writes: > Compared to v2: > > * rebased to latest master > > * patch 1 and 2 > I kept them in, but if Junio prefers them separately then I'll send > them as separate patches. It's not just me, but I think they should be separated out (I can just queue them

[PATCH v3 00/14] Some fixes and bunch of object_id conversions

Compared to v2: * rebased to latest master * patch 1 and 2 I kept them in, but if Junio prefers them separately then I'll send them as separate patches. * patch 5 - strbuf_add(buf, sha1_to_hex(oid.hash), GIT_SHA1_HEXSZ); + strbuf_addstr(buf, oid_to_hex()); * patch 7 On suggestion from Duy