Re: [PATCH v3 00/36] object_id part 12

On Wed, Mar 14, 2018 at 09:48:30AM -0700, Junio C Hamano wrote: > As always, thanks for working on this. > > After this series, what jumps at me out of output from > > git grep -e '[^0-9A-Za-z_][24]0[^0-9A-Za-z_]' -- '*.[ch]' \ > ':!*sha1*' ':!contrib/' ':!compat/' > > are

Re: [PATCH v3 00/36] object_id part 12

On Wed, Mar 14, 2018 at 10:31:37AM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > > -+ buf += the_hash_algo->rawsz; > > -+ size -= the_hash_algo->rawsz; > > ++ memcpy(it->oid.hash, (const unsigned

Re: [PATCH v3 00/36] object_id part 12

Junio C Hamano writes: > "brian m. carlson" writes: > >> This is the twelfth in a series of patches to convert various parts of >> the code to struct object_id. >> >> brian m. carlson (36): >> ... > As always, thanks for working on this.

Re: [PATCH v3 00/36] object_id part 12

"brian m. carlson" writes: > -+buf += the_hash_algo->rawsz; > -+size -= the_hash_algo->rawsz; > ++memcpy(it->oid.hash, (const unsigned char*)buf, rawsz); > ++buf += rawsz; > ++

Re: [PATCH v3 00/36] object_id part 12

"brian m. carlson" writes: > This is the twelfth in a series of patches to convert various parts of > the code to struct object_id. > > Changes from v2: > * Rebase onto master (to fix "typename" → "type_name" changes). > * Replace some uses of hashcpy with memcpy. >

[PATCH v3 00/36] object_id part 12

This is the twelfth in a series of patches to convert various parts of the code to struct object_id. Changes from v2: * Rebase onto master (to fix "typename" → "type_name" changes). * Replace some uses of hashcpy with memcpy. * Replace some instances of "20" with references to the_hash_algo.