Re: [PATCH v3 05/13] worktree.c: mark current worktree

2016-05-10 Thread Duy Nguyen
On Wed, May 11, 2016 at 6:03 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On second thought, why hold patches back, lengthen the worktree-move >> series and make it a pain to review? I moved a few patches from >> worktree-move into this series and I

Re: [PATCH v3 05/13] worktree.c: mark current worktree

2016-05-10 Thread Junio C Hamano
Duy Nguyen writes: > On second thought, why hold patches back, lengthen the worktree-move > series and make it a pain to review? I moved a few patches from > worktree-move into this series and I took two other out to create > nd/error-errno. So I'm going to take more patches

Re: [PATCH v3 05/13] worktree.c: mark current worktree

2016-05-10 Thread Junio C Hamano
Duy Nguyen writes: > On second thought, why hold patches back, lengthen the worktree-move > series and make it a pain to review? I moved a few patches from > worktree-move into this series and I took two other out to create > nd/error-errno. So I'm going to take more patches

Re: [PATCH v3 05/13] worktree.c: mark current worktree

2016-05-10 Thread Duy Nguyen
On Fri, May 06, 2016 at 05:21:05PM +0700, Duy Nguyen wrote: > > Similarly, it looks like 'path' doesn't need to be a strbuf at all > > since the result of absolute_path() should remain valid long enough > > for fspathcmp(). It could just be: > > > > const char *path = absolute_path(...); > >

Re: [PATCH v3 05/13] worktree.c: mark current worktree

2016-05-06 Thread Duy Nguyen
On Fri, May 6, 2016 at 2:51 PM, Eric Sunshine wrote: > On Fri, Apr 22, 2016 at 9:01 AM, Nguyễn Thái Ngọc Duy > wrote: >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> diff --git a/worktree.c b/worktree.c >> @@ -147,6 +150,25 @@

Re: [PATCH v3 05/13] worktree.c: mark current worktree

2016-05-06 Thread Eric Sunshine
On Fri, Apr 22, 2016 at 9:01 AM, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > diff --git a/worktree.c b/worktree.c > @@ -147,6 +150,25 @@ done: > +static void mark_current_worktree(struct worktree **worktrees) > +{ > +

[PATCH v3 05/13] worktree.c: mark current worktree

2016-04-22 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- worktree.c | 24 worktree.h | 1 + 2 files changed, 25 insertions(+) diff --git a/worktree.c b/worktree.c index 360ba41..dc092a7 100644 --- a/worktree.c +++ b/worktree.c @@ -2,6 +2,7 @@ #include "refs.h"