Re: [PATCH v3 1/2] fsck.c: modify fsck_ident() and fsck_commit()

2014-03-25 Thread Eric Sunshine
On Mon, Mar 24, 2014 at 8:08 AM, Ashwin Jha ajha@gmail.com wrote: Subject: fsck.c: modify fsck_ident() and fsck_commit() The subject should summarize the change while being concise and expressive. The above is a bit lacking. A better subject might be: Subject: fsck: add missing 'const's

[PATCH v3 1/2] fsck.c: modify fsck_ident() and fsck_commit()

2014-03-24 Thread Ashwin Jha
In fsck_ident(): Replace argument char **ident with const char **ident In fsck_commit(): Replace char *buffer with const char *buffer In both the cases, referenced memory addresses are not modified. So, it will be a good practice, to declare them as const. Signed-off-by: Ashwin Jha