On Thu, Aug 11, 2016 at 01:02:52AM -0400, Jeff King wrote:
> > > + * 2. Updating our size; check_object() will have filled in the size
> > > of our
> > > + * delta, but a non-delta object needs it true size.
> >
> > Excellent point.
>
> I was not clever enough to think of it; the pack-ob
On Wed, Aug 10, 2016 at 01:17:22PM -0700, Junio C Hamano wrote:
> > Actually, skimming the sha1_file code, I am not 100% sure that we detect
> > cycles in OBJ_REF_DELTA (you cannot have cycles in OBJ_OFS_DELTA since
> > they always point backwards in the pack). But if that is the case, then
> > I
Jeff King writes:
> ...
> We could do analysis on any cycles that we find to
> distinguish the two cases (i.e., it is a bogus pack if and
> only if every delta in the cycle is in the same pack), but
> we don't need to. If there is a cycle inside a pack, we'll
> run into problems not only reusing
We do not allow cycles in the delta graph of a pack (i.e., A
is a delta of B which is a delta of A) for the obvious
reason that you cannot actually access any of the objects in
such a case.
There's a last-ditch attempt to notice cycles during the
write phase, during which we issue a warning to the
4 matches
Mail list logo
