On Mon, Feb 11, 2013 at 1:00 AM, Jonathan Nieder jrnie...@gmail.com wrote:
By the way, regarding what the right --signoff behavior is for
commit, cherry-pick, am, and format-patch:
I think the best behavior would be to check if the last signed-off-by
line (ignoring acked-by, bug, change-id,
On Sun, Jan 27, 2013 at 7:39 PM, Jonathan Nieder jrnie...@gmail.com wrote:
Brandon Casey wrote:
--- a/log-tree.c
+++ b/log-tree.c
[...]
@@ -208,94 +207,6 @@ void show_decorations(struct rev_info *opt, struct
commit *commit)
putchar(')');
}
-/*
- * Search for ^[-A-Za-z]+: [^@]+@
There are two implementations of append_signoff in log-tree.c and
sequencer.c, which do more or less the same thing. Unify on top of the
sequencer.c implementation.
Add a test in t4014 to demonstrate support for non-s-o-b elements in the
commit footer provided by sequence.c:append_sob. Mark
Brandon Casey wrote:
--- a/log-tree.c
+++ b/log-tree.c
[...]
@@ -208,94 +207,6 @@ void show_decorations(struct rev_info *opt, struct
commit *commit)
putchar(')');
}
-/*
- * Search for ^[-A-Za-z]+: [^@]+@ pattern. It usually matches
- * Signed-off-by: and Acked-by: lines.
- */
4 matches
Mail list logo
