Re: [PATCH v3 15/19] pkt-line: share buffer/descriptor reading implementation

2013-02-22 Thread Eric Sunshine
On Wed, Feb 20, 2013 at 3:04 PM, Jeff King wrote: > diff --git a/pkt-line.h b/pkt-line.h > index fa93e32..47361f5 100644 > --- a/pkt-line.h > +++ b/pkt-line.h > @@ -25,9 +25,16 @@ void packet_buf_write(struct strbuf *buf, const char *fmt, > ...) __attribute__((f > void packet_buf_write(struct st

[PATCH v3 15/19] pkt-line: share buffer/descriptor reading implementation

2013-02-20 Thread Jeff King
The packet_read function reads from a descriptor. The packet_get_line function is similar, but reads from an in-memory buffer, and uses a completely separate implementation. This patch teaches the generic packet_read function to accept either source, and we can do away with packet_get_line's implem