Re: [PATCH v3 2/2] completion: add git status

2016-06-03 Thread Thomas Braun
Am 03.06.2016 um 19:54 schrieb Junio C Hamano: > Jeff King writes: > >> I know not everybody will the "natural thing" I claim, and if it were >> easy to support everywhere, I don't mind doing it. But I suspect >> (without thinking very hard on it) that it would make those case >>

Re: [PATCH v3 2/2] completion: add git status

2016-06-03 Thread Junio C Hamano
Jeff King writes: > I know not everybody will the "natural thing" I claim, and if it were > easy to support everywhere, I don't mind doing it. But I suspect > (without thinking very hard on it) that it would make those case > statements a bit harder to read and maintain. Oh, I

Re: [PATCH v3 2/2] completion: add git status

2016-06-03 Thread Jeff King
On Fri, Jun 03, 2016 at 09:34:00AM -0700, Junio C Hamano wrote: > Thomas Braun writes: > > >>> + if [ -n "$(__git_find_on_cmdline "--ignored")" ]; then > >> > >> Same question as the "--untracked-files=no vs -uno" applies here. > > > > Is there

Re: [PATCH v3 2/2] completion: add git status

2016-06-03 Thread Junio C Hamano
Thomas Braun writes: >>> + if [ -n "$(__git_find_on_cmdline "--ignored")" ]; then >> >> Same question as the "--untracked-files=no vs -uno" applies here. > > Is there a short version of --ignored? I could not find one in the help, > and from a

Re: [PATCH v3 2/2] completion: add git status

2016-06-03 Thread Thomas Braun
Am 02.06.2016 um 20:14 schrieb Junio C Hamano: > Thomas Braun writes: > >> +untracked_state="$(__git_find_on_cmdline "--untracked-files=no\ >> +--untracked-files=normal --untracked-files=all")" > > Just wondering but does this help my use of the

Re: [PATCH v3 2/2] completion: add git status

2016-06-02 Thread Junio C Hamano
Thomas Braun writes: > + untracked_state="$(__git_find_on_cmdline "--untracked-files=no\ > + --untracked-files=normal --untracked-files=all")" Just wondering but does this help my use of the command like $ git status -uno or do I now

[PATCH v3 2/2] completion: add git status

2016-06-02 Thread Thomas Braun
Signed-off-by: Thomas Braun --- contrib/completion/git-completion.bash | 55 ++ 1 file changed, 55 insertions(+) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index addea89..fa7a03a