Re: [PATCH v3 2/3] diff: Let git diff -O read orderfile from any file, failing when appropriate

2013-12-16 Thread Junio C Hamano
Samuel Bronson naes...@gmail.com writes: The -O flag really shouldn't silently fail to do anything when given a path that it can't read from. However, it should be able to read from un-mappable files, such as pipes/fifos, /dev/null (as we document in the next patch), or in fact *any* empty

[PATCH v3 2/3] diff: Let git diff -O read orderfile from any file, failing when appropriate

2013-12-14 Thread Samuel Bronson
The -O flag really shouldn't silently fail to do anything when given a path that it can't read from. However, it should be able to read from un-mappable files, such as pipes/fifos, /dev/null (as we document in the next patch), or in fact *any* empty file (since Linux 2.6.12). (Especially since